Thread: Function result as a string

Hi, here I have a small function, that checks if the string doesn't exceed 10 characters - now I'm stuck with a problem - pointer... How should I tell that the value of the function is variable "nos" - I tried different variants, but it seems that I won't get more than just errors

Code:

char *string3 (char *s){
int n;
char *nos;

n=1;

printf("%s: ",s);

while (((scanf("%s",&nos)) != 1) || ((strlen(nos))>10))
  {
   clrscr();
   while (getchar()!='\n');
    printf ("Error nr. %d. Try again.\n%s: ",n,s);
    n+=1;
  }
}

What you said you were doing, and what you did aren't the same. What are you really attempting to do?

Sorry, if I didn't explain you the problem correctly - what would you like to know? I must say, that the code works fine, I just don't understand how to pass variable nos to function string3 at the end - return ...?

Code:

char *nos;

n=1;

printf("%s: ",s);

while (((scanf("%s",&nos)) != 1) || ((strlen(nos))>10))

There is NO WAY this can work fine. nos is pointing to NOTHING, yet you are dereferencing that nothingness to get a string from scanf. THIS IS BROKEN CODE. IT CANNOT WORK, PERIOD. So, as I stated before, what you said you were doing and what you did aren't the same.

Please CLEARLY state the problem and post _ALL_ of your code if you want help.

Sorry, just tried it, and I must say you're right - it doesn't work. It seems that I've mistyped something while posting this topic, unfortunately I haven't saved the previous version :/ I'll try to rewrite it.

Well.. the point (at least top begin with) is you never allocate any space for 'nos'.

Originally Posted by nowber

Hi, here I have a small function, that checks if the string doesn't exceed 10 characters - now I'm stuck with a problem - pointer... How should I tell that the value of the function is variable "nos" - I tried different variants, but it seems that I won't get more than just errors

Code:

char *string3 (char *s){
int n;
char *nos;

n=1;

printf("%s: ",s);

while (((scanf("%s",&nos)) != 1) || ((strlen(nos))>10))
  {
   clrscr();
   while (getchar()!='\n');
    printf ("Error nr. %d. Try again.\n%s: ",n,s);
    n+=1;
  }
}

There are so many problems in the code
first of all what do you want to do ??? first major question from me

and

this function signature says it should return something of char* which is not returning any thing error

in the while loop what you want to do is out of my mind

you are incrementing n and you are making no use of it

you are scanning nos prinint s

and the biggest thing is segmentation fault with this code

and the major problem with you type of guys is you won't compile the code at your end and you just post the code here