Thread: tokenize a string

help me out.

Code:

#include <stdio.h> 
#include <string.h> 

#define DELIM   " , \n" 
#define MAXWORD 80 
#define MAXLEN  20 

int tokenize(char *str, char **tokens)
  {
    char  *sep = strtok(str, DELIM);
    int i=0;
    while (sep != NULL)
    {
      strcpy(tokens[i++], sep);
      sep = strtok(NULL, DELIM);
    }
    return i;
  }


int main(void)
{
  char  parameters[MAXWORD][MAXLEN];
  char  toserver[BUFSIZ];
  int   ntokens = 0;
  int i;
  printf("Enter a string: ");
  fflush(stdout);

  if (fgets(toserver, sizeof toserver, stdin) != NULL)
	ntokens=tokenize(toserver,parameters);

  for (i = 0; i < ntokens; i++) 
  {
    puts(parameters[i]);
  }

  return(0);
}

i want to store the tokens in the parameter array but i got a compilation error in line 31 saying "passing argument 2 of 'tokenize' from incompatible pointer type"

what's wrong with the code?

parameters is not a pointer to pointer to char; it was declared as a double array of char, and when used by itself it decays to a pointer to an array of char (decay only happens once, not recursively).

You're trying to pass the 2D array parameters[][], as a 1D array, in the call to tokenize().

You have two asterisks in tokenize(), but what about the calling line of code?

should i initialize parameters as char **parameters instead?

What does your instructor say he wants you to do?

There's more than one way to do this. You can use pointers, or you can use index's, or you can even mix them a bit.

It's best to follow what your teacher/prof is telling you to do. If you're following a book, then use the same style that the book is using, at that time.

I'd stick with using indexes for beginners, rather than pointers (so, no). Later, you'll surely learn both.

i want to make tokenize a function so that i could reuse it everytime there's a new string to be tokenized. i followed the code from the prelude but the tokenize mechanism is in the main function.

for example i got another string and I need to tokenize it, i don't want to write

Code:

    char  *sep = strtok(toserver, DELIM);

    while (sep != NULL)
    {
      strcpy(parameters[ntokens++], sep);
      sep = strtok(NULL, DELIM);
    }

allover again.
thanks/

The main point is that you need to make the two agree. Arrays are (far) easier, so I would suggest making them both arrays.