Thread: Need Help in Reading Text in C

Hi All, I am having problem reading text in C. I appreciate any help. Thanks YetBo.

Code:

/*Using Microsoft Visual Studio 2006
 Tafe NSW
*/
#include <stdio.h>
#include <stdlib.h>

void main()
{
	int Id,Number,Value;
	char Code,First[20],Last[20];
//Open the file using read mode
	FILE *fp = fopen("Myfile.txt","r");
	printf("Id \tNumber \tFirst \tLast \tCode\tValue\n");
//Checks if EndOfFile
	while(!feof(fp))	{
//Need help in reading the names, doesn't read/display properly ??? 
		fscanf(fp,"%d,%d,%s,%s,%c,%d",&Id,&Number,First,Last,&Code,&Value);
		printf("%d\t%d\t%s\t%s\t%c\t%d\n",Id,Number,First,Last,Code,Value);
	}
	system("pause");

/* This is my test file <Myfile.txt>
1,3,James,Bond,a,40
2,4,Clint,Eastwood,s,52
3,5,Bart,Simpson,,d,50
*/
}

First, that should be

Code:

int main(void)

Now, on to the real issue. For future reference, it is helpful to explain what is going wrong with your code. Simply stating you have a "problem" is not helpful. I can make a guess, though, and this is it: %s reads as much (non-whitespace) text as it can. That means if you give it a comma, it will read that comma, regardless of what your format string looks like. So your first %s is eating the rest of each line. You can use %[^,] instead of %s; this means "any character except a comma".

It's also usually a bad idea to loop on feof(). Instead, check the return value of your read function; it will tell you if there's been a problem. In this case, fscanf() returns the number of successful conversions. You expect 6, so if it returns anything else, you've got a problem (or EOF). If you use your code as it stands, it will appear to process the last line twice, which your probably don't want. Actually, if that double comma in the last line is really in your data file, it will loop endlessly. Neither of these occurrences would happen if you looped on the return value of fscanf().

Thanks for the quick reply cas and MK27.

Sorry it's my first time to post.

Below is the problem I encounter in my program.
1.) Problem reading text/name ... Resolved now thanks to both of you.
2.) In Id#2 the code 's' is not aligned.
3.) Last line displayed twice.
You were right 'cas' the comma in my file should only be one instead of two.
I don't know yet to how to return the value for fscanf(). I will search how to return the value.

Thanks again to both of you,
YetBo

Your alignment can be improved by using the set field feature of printf().

Try this:

Code:

printf("     %4d\n     %4d", 1,100);

The 4 means that the field width for the numbers will be set to 4 char's width, no matter what the size is of the number. Really helpful, and you can change the 4 to any size you want, to improve difficult alignment problems.

Thanks Adak.

You are very welcome, YetBo.

I tried to work out your problem with the commas - but I fell asleep at the keyboard.

Glad it's all working for you.