Thread: calculation problem

I cannot figure out why this program will not calculate the final balance. I enter the end bal and the outdep and the with but in the final balance, keeps coming up with the same amount entered as the end bal.

Any help would be appreciated.

Thanks

Code:

#include <stdio.h>

#define SENTINEL 0

float endbal,
	  finbal;
int	  date,
	  outdep,
	  withdraw;

int main (void)


{

		  printf("BANK RECONCILIATION FOR: 10/21/98");

		  printf("\n\nEnding balance on statement:");
		  scanf ("%f", & endbal);


		  printf("Enter Outstanding dep (or %d to quit)>", SENTINEL);
		  scanf ("%f", & outdep);

while (outdep!= SENTINEL)
	{
		finbal = finbal + outdep;
		printf("Enter outstanding dep (%d to quit)>", SENTINEL);
		scanf("%f", & outdep);

	}

printf("Outstanding check/withdrawal (or %d to quit)>", SENTINEL);
scanf ("%d", & withdraw);

while (withdraw!=SENTINEL)
	{
		finbal = finbal - withdraw;
		printf("Enter withdrawal (%d to quit)>", SENTINEL);
		scanf("%f", & withdraw);

	}

    finbal = endbal + outdep - withdraw;

	printf("Your final balance in your checkbook should be $ %f\n" , finbal);

	return 0;

  }

Code:

     finbal = endbal + outdep - withdraw;

By the time that you get to this line of code endbal hasn't changed, outdep = 0 and withdraw = 0.

In the end you do:

Code:

finbal = endbal + outdep - withdraw

So finbal = endbal
outdep = withdraw = SENTINEL = 0 since you exit from the loops

Maybe you wanted just:

Code:

finbal = finbal  + endbal

Also, you have unecessary code

Code:

		  
printf("Enter Outstanding dep (or %d to quit)>", SENTINEL);
scanf ("%f", & outdep);
while (outdep!= SENTINEL)
	{
		finbal = finbal + outdep;
		printf("Enter outstanding dep (%d to quit)>", SENTINEL);
		scanf("%f", & outdep);

	}

Can be done like:

Code:

do	{
		finbal = finbal + outdep; //outdep is 0 in the beginning
		printf("Enter outstanding dep (%d to quit)>", SENTINEL);
		scanf("%f", & outdep);                
	} while (outdep!= SENTINEL);

This works, within the limitations of the accuracy of floats, which can't represent all dollars and cents, accurately.

Code:

#include <stdio.h>

#define SENTINEL 0

float endbal, finbal, outdep, withdraw;

int main (void)


{

		  printf("BANK RECONCILIATION FOR: 10/21/98");

		  printf("\n\nEnding balance on statement:");
		  scanf ("%f", &endbal);


		  printf("Enter Outstanding dep (or %d to quit)>", SENTINEL);
		  scanf ("%f", &outdep);

while (outdep!= SENTINEL)
	{
		finbal = finbal + outdep;
		printf("Enter outstanding dep (%d to quit)>", SENTINEL);
		scanf("%f", &outdep);

	}

printf("Outstanding check/withdrawal (or %d to quit)>", SENTINEL);
scanf ("%f", &withdraw);

while (withdraw!=SENTINEL)
	{
		finbal = finbal - withdraw;
		printf("Enter withdrawal (%d to quit)>", SENTINEL);
		scanf("%f", &withdraw);

	}
    /* the outstanding deposits and withdrawals, are already sub-totaled
    into finbal. So this is all you need:
    */

    finbal = finbal + endbal;

	printf("Your final balance in your checkbook should be $ %f\n" , finbal);

	return 0;

  }

If you need more accuracy, you can either:

1) "normalize" the errors out of the float values

or

2) throw away the float data types, and use int's for dollars, and int's for cents.

I changed and then did an execute and this is what my answer was. Still wrong answer for finbal. Thanks for all of your advice on the above changes.



BANK RECONCILIATION FOR: 10/21/98

Ending balance on statement:10
Enter outstanding dep (0 to quit)>10
Enter outstanding dep (0 to quit)>10
Enter outstanding dep (0 to quit)>10
Enter outstanding dep (0 to quit)>0
Enter outstanding dep (0 to quit)>5
Outstanding check/withdrawal (or 0 to quit)>5
Enter withdrawal (0 to quit)>5
Enter withdrawal (0 to quit)>0
Your final balance in your checkbook should be $ 2193620992.000000

"c:\cop2000\a5\lcc2\score.exe"
Return code 0
Execution time 9.094 seconds
Press any key to continue...

I changed it back to the way you stated that I should have, I was listening to the other person that was trying to tell me to shorten some of the code. Then I really messed up. Thank you for your help with this Adak.

You're welcome and I'm glad it's working.

Please keep just *one* thread per subject on the forum, in the future. Bump up the thead, if it needs it.