Thread: What is wrong with my code?

here...

Code:

while((strcmp(pn,cmd3) !=  0) && (searchn < 2)){    	
	printf("\n pn= \"%s\"\n",pn);    
	fflush(stdout);	
	printf("search for\n");	
	scanf("%27[a-zA-Z0-9_-]", pn);	
	searchn++;	
	}

Yes, I'm aware of where the scanf line is. I wanted you to actually read and learn from what I've been saying to you. But I see that's far too much to ask of you...

Code:

#include <stdio.h>
#include <string.h>
#define c ".c"
#define cmd1 "electropulse"
#define cmd2 "weight"
#define cmd3 "exit"

/* eeew globals */
int var[100];
int var2[100];
int searchn = 0;
int lookn = 0;
char pn[100];

FILE *f;

int main() {
    printf("Project name: ");
    scanf("%27[a-zA-Z0-9_-]", pn);
    strcat(pn,c);

    while(pn != cmd3 && searchn<2){    	
        printf("search for\n");	
        scanf("%27[a-zA-Z0-9_-]", pn);	
        if( strcmp( pn, cmd1 ) == 0 ){
            printf("cmd1\n");
            var[0]=1;    	
        }
        if( strcmp( pn, cmd2) == 0 ){
            printf("cmd2\n");
            var[1]=1;	
        }
        searchn++;	
        printf("pn = \'%s\'\n", pn );
    }

    return 0;
}


/* output: */
Project name: search for
pn = 'foo.c'
search for
pn = 'foo.c'

There, see, wasn't that hard now was it?

Now if we quickly look at the output, we see that like I said, you've got a newline stuck in your buffer, because you never take it out after the first scanf call.


Quzah.

Originally Posted by quzah

Now if we quickly look at the output, we see that like I said, you've got a newline stuck in your buffer, because you never take it out after the first scanf call.

Yeah. scanf() has something to read, '\n', but it is not in the category [a-zA-Z0-9_-], so it fails right away.

To get rid of the newline at the end of your input, you could do this

Code:

int r;
r=scanf("%27[a-zA-Z0-9_-]%*1[\n]", pn);

%*1[/n] means get one newline, and ignore (*) it. The "r" is so you can test the return value of scanf when debugging:

Code:

printf("\npn=\"%s\"\tr=%d\n"),pn,r); fflush(stdout);

OK, I just used "%s" instead of "%27[a-zA-Z0-9_-]"...
Sorry quzah, don't get upset so easy, i didn't notice that newline!

I'm not upset. You just need to learn how to debug and ask smart questions. It'll save you a lot of head aches in the long run. Just remember, every time you hit enter, unless you're using a function that specifically pulls it out, it's going to still be there.


Quzah.

Originally Posted by yann

OK, I just used "%s" instead of "%27[a-zA-Z0-9_-]"...
Sorry quzah, don't get upset so easy, i didn't notice that newline!

There's a problem with that: "exit\n" will not match "exit" when you want to compare strings. Etc. Get it? That's why it is better to throw the newline away -- not keep it in the string.