Thread: newb help

I am writing a program to a class. It is pretty self explanatory on what is supposed to happen but the math is coming up completely wrong. Any help?

Code:

#include<stdio.h>
#define POUNDS 16 // 1lbs = 16 oz
#define KILOGRAMS 1000 // 1kilogram = 1000 grams
#define OUNCE .028 // ounce/kilo
#define GRAM 28.35 // ounce/gram
int main(void)
{
 int lbs, oz;
 float kg, g;

 printf("Enter pounds\n");
 scanf("%d", &lbs);
 printf("Enter ounces\n");
 scanf("%d",&oz);
 printf("The weight converted to kilograms is %d\n ",((lbs * POUNDS)+ oz)* OUNCE);
 printf("The weight converted to grams is %d\n ",((lbs * POUNDS)+ oz)* GRAM);

return 0;

Enter pounds
1
Enter ounces
1
The weight converted to kilograms is -1271310319
The weight converted to grams is 858993460


This is the i/o. I tried fixing what you had said the but numbers hadn't changed....

Try working out your formulas on paper --- you will see they are bogus. It might help if you defined your constants better. Instead of "POUNDS" doesn't something like "OZ_PER_LB" sound more accurate?

Your ((lbs * POUNDS)+ oz)* GRAM) ---- is this really what you want? You are adding "oz" to (lbs * POUNDS).

I didn't see the second half of the reply. Thanks! It ended up working. I'm still learning so I am sure i'll have more questions but thanks again!

Code:

...
#define OUNCE .028 // ounce/kilo
#define GRAM 28.35 // ounce/gram
...

I'm glad your problem has been solved, but I couldn't help but point this out. You mean kilo/ounce and gram/ounce rather than what you have. The constants are correct for what you are doing with them, but the notes are upside-down