error in comparing pointer and intger

[clag]

delete

[quzah]

You shouldn't be comparing it to null, you should be comparing it to '\0' ... it's not the same thing. Why don't you just use fputs?


Quzah.

[clag]

what should I return if I use fputs...will mine still be valid?

[quzah]

Your function is a void fuction. You can't return anything.


Quzah.

[clag]

delete

[clag]

if I just use fputc, it compiles fine, but is the program erroneous?

[rags_to_riches]

man fputs:
[code=cpp]int fputs(const char *restrict s, FILE *restrict stream);[/code]

When you do this:

message[index]

with a

const char *message

you're passing a character, not a pointer to a character. That's what the compiler is complaining about.

Any reason you're not just doing

fprintf(stderr, message);

???

[clag]

cause Values of message are expected to be a NULL terminated character arrays.

[quzah]

Just pass message, not one character from it.


Quzah.

[clag]

delete

[quzah]

What are you trying to return? I mean, you're passing along a message and a place to write it, but what are you trying to have it return? What do you want your return value to mean or indicate?


Quzah.

[ssharish2005]

>but i feel like i'm returning it incorrectly..cuz message[index] would just be message[0] since it exited the loop.
>should i just return message? but that's not long..
Well, this doesn’t make any sense. You cant return long using char *. And why do you expect the index to be 0. Its declared within the function scope and to try to increment in the while loop which is still visible to all those usages in index within the function scope.

Now tell us what you are trying to return from the function?

~ssharish

[clag]

delete

[tabstop]

So in this example, your main neither wants nor expects you to return anything; so don't.

[quzah]

void writeline( const char *s, FILE *f )
{
    if( s && f )
        fputs( s, f );
}

So just use fputs like we said a long time ago.


Quzah.