Thread: problem with printing elements of a array using recursion program

problem with printing elements of a array using recursion program

Code:

#include<stdio.h>
void pa(int [],int,int);
int main()
{

int a[14]={10,20,30,40};
 pa(a,0,3);
}
void pa(int a[],int lb,int ub)
{
       if(lb==ub)
       printf("%d",a[lb]);
       else
       {
           printf("%d",a[lb]);
           pa(a,lb+1,ub);
       }
}

there is some problem with the above code.....please find where it went wrong.......

Originally Posted by cooldude

problem with printing elements of a array using recursion program

Code:

#include<stdio.h>
void pa(int [],int,int);
int main()
{
int lb=0,ub=3;
int a[10]={10,20,30,40};
void pa(int a[],int lb,int ub);
}
void pa(int a[],int lb,int ub)
{
       if(lb==ub)
       printf("%d",a[lb]);
       else
       {
           printf("%d",a[lb]);
           pa(a,lb+1,ub);
       }
}

there is some problem with the above code.....please find where it went wrong.......

You've declared the function at two places and not called it anywhere.
Also I dont get why you're declaring an array of 10 ints while there are only 5 in it.

Originally Posted by nadroj

oooh, its like a game!

"void pa(int a[],int lb,int ub);" is not how you call a function, this would be an example of how to call a function:

Code:

#include<stdio.h>

void foo (int bar)
{
     // do something
}

int main()
{  
    foo(5);
    return 0;
}

also, you have a function "int main" (correct), but you dont "return" anything, but im sure you know that when you saw the compiler warning.

I guess that he knows how to call a function coz he's actually calling it recursively in the "pa" function.
Also according to C99 return is optional in C, but yeah it's good to return 0 in the end.

Originally Posted by nadroj

oooh, its like a game!

LOL!

@cooldude: absolute worst practice at programming forum: present code and then tell everyone else to find the problem! You already know there is a problem, and you have gotten error messages, etc, about it. You probably even know the line numbers. Why don't you just explain yourself PROPERLY AND INTELLIGENTLY to begin with?

Originally Posted by cooldude

the above did not get any error, its compiled but i did not get correct output.....iam a beginner in C progamming....so i asked u guys to help me...
if u r not interested to help me, then simply quit , but dont post useless messages.............hope u will understand..........

Okay, let's get something straight about who is posting useless messages. I was just guessing that you got an error. I was wrong -- but why did I even have to guess? Let's look at all the useful information in your original post:

there is some problem with the above code.....please find where it went wrong.......

Now you are saying "the above did not get any error, its compiled but i did not get correct output". Better. Why did you not just say that in the first place? If the answer is you are too lazy, why do you expect others to bother helping? You could even explain EXACTLY what output you expected and EXACTLY what output you got, if you want to be really clear and get a quick, helpful reply.

But trying to help a lazy person is very often a waste of time, because at the same time as they are too lazy to bother communicating effectively, they are also bound to be too lazy to bother paying attention to any of the advice they get.

I am here A LOT. I answer A LOT of questions. I read pretty much every single thread in the C forum. I promise if you pay attention to what I am telling you in this post, it will be much easier for you to get advice and solve problems.

Go back and edit your last post, or post again, with all the information you have. Unless, as nadroj says, you think this is some kind of game we are suppose to play with you.

i modified the code...but still iam not getting any output........the code was compiled and there are no errors.....

Code:

#include<stdio.h>
void pa(int [],int,int);
 main()
{
int a[4]={10,20,30,40};
 pa(a,0,3);
}
void pa(int a[],int lb,int ub)
{
       if(lb==ub)
       printf("%d",a[lb]);
       else
       {
           printf("%d",a[lb]);
           pa(a,lb+1,ub);
       }
}

Originally Posted by cooldude

i modified the code...but still iam not getting any output........the code was compiled and there are no errors.....

Code:

#include<stdio.h>
void pa(int [],int,int);
 main()
{
int a[4]={10,20,30,40};
 pa(a,0,3);
}
void pa(int a[],int lb,int ub)
{
       if(lb==ub)
       printf("%d",a[lb]);
       else
       {
           printf("%d",a[lb]);
           pa(a,lb+1,ub);
       }
}

Deleting the int before main did not change anything. Main still returns int, because the compiler assumes int as the return type if none is given. Further, main must return int, to be standard C. Therefore you need to put a return 0 at the end of main. (you can also return something else to tell the OS you got an error, or perhaps some useful information.

There is a FAQ on that:

Cprogramming.com FAQ > Stop my Windows Console from disappearing everytime I run my program?


Quzah.