Thread: problem with printing elements of a array using recursion program

problem with printing elements of a array using recursion program

Code:

#include<stdio.h>
void pa(int [],int,int);
int main()
{

int a[14]={10,20,30,40};
 pa(a,0,3);
}
void pa(int a[],int lb,int ub)
{
       if(lb==ub)
       printf("%d",a[lb]);
       else
       {
           printf("%d",a[lb]);
           pa(a,lb+1,ub);
       }
}

there is some problem with the above code.....please find where it went wrong.......

Originally Posted by cooldude

problem with printing elements of a array using recursion program

Code:

#include<stdio.h>
void pa(int [],int,int);
int main()
{
int lb=0,ub=3;
int a[10]={10,20,30,40};
void pa(int a[],int lb,int ub);
}
void pa(int a[],int lb,int ub)
{
       if(lb==ub)
       printf("%d",a[lb]);
       else
       {
           printf("%d",a[lb]);
           pa(a,lb+1,ub);
       }
}

there is some problem with the above code.....please find where it went wrong.......

You've declared the function at two places and not called it anywhere.
Also I dont get why you're declaring an array of 10 ints while there are only 5 in it.

Originally Posted by nadroj

oooh, its like a game!

"void pa(int a[],int lb,int ub);" is not how you call a function, this would be an example of how to call a function:

Code:

#include<stdio.h>

void foo (int bar)
{
     // do something
}

int main()
{  
    foo(5);
    return 0;
}

also, you have a function "int main" (correct), but you dont "return" anything, but im sure you know that when you saw the compiler warning.

I guess that he knows how to call a function coz he's actually calling it recursively in the "pa" function.
Also according to C99 return is optional in C, but yeah it's good to return 0 in the end.

Originally Posted by nadroj

oooh, its like a game!

LOL!

@cooldude: absolute worst practice at programming forum: present code and then tell everyone else to find the problem! You already know there is a problem, and you have gotten error messages, etc, about it. You probably even know the line numbers. Why don't you just explain yourself PROPERLY AND INTELLIGENTLY to begin with?

i modified the code...but still iam not getting any output........the code was compiled and there are no errors.....

Code:

#include<stdio.h>
void pa(int [],int,int);
 main()
{
int a[4]={10,20,30,40};
 pa(a,0,3);
}
void pa(int a[],int lb,int ub)
{
       if(lb==ub)
       printf("%d",a[lb]);
       else
       {
           printf("%d",a[lb]);
           pa(a,lb+1,ub);
       }
}

Originally Posted by cooldude

the above did not get any error, its compiled but i did not get correct output.....iam a beginner in C progamming....so i asked u guys to help me...
if u r not interested to help me, then simply quit , but dont post useless messages.............hope u will understand..........

Okay, let's get something straight about who is posting useless messages. I was just guessing that you got an error. I was wrong -- but why did I even have to guess? Let's look at all the useful information in your original post:

there is some problem with the above code.....please find where it went wrong.......

Now you are saying "the above did not get any error, its compiled but i did not get correct output". Better. Why did you not just say that in the first place? If the answer is you are too lazy, why do you expect others to bother helping? You could even explain EXACTLY what output you expected and EXACTLY what output you got, if you want to be really clear and get a quick, helpful reply.

But trying to help a lazy person is very often a waste of time, because at the same time as they are too lazy to bother communicating effectively, they are also bound to be too lazy to bother paying attention to any of the advice they get.

I am here A LOT. I answer A LOT of questions. I read pretty much every single thread in the C forum. I promise if you pay attention to what I am telling you in this post, it will be much easier for you to get advice and solve problems.

Go back and edit your last post, or post again, with all the information you have. Unless, as nadroj says, you think this is some kind of game we are suppose to play with you.

Originally Posted by cooldude

and during our communication , if anything hurts u , then Iam sorry................

Well, I am not trying to be your enemy of course and the only person I get angry at is Mario F., who has the good sense to stay out of the C forum But when I wrote "absolute worst practice" I did mean it.

I am just saying, as someone who could potentially help you out, how you can get the best out of a forum, based on my experience. I am doing that because I recognize you are new. I understand that you may have "thought it could be sufficient to solve my problem" (maybe it is!); what I am telling you is that it would be better to think about how you can ask a question "in the best way", and not assume that things like desired outcome and actual outcome are irrelevant or superfluous:

How To Ask Questions The Smart Way

If you look under "translations", you will notice that has been translated into more than 20 languages, which is 19 more than 95% of actual programming tutorials. I wonder who thinks this is so important and why?

Now, I compiled and ran your last posted code. Here is the output:

10203040

That is exactly what I would expect, so what are you complaining about? Other than the fact that main() should always be of type int and return an int value, there is nothing wrong with your code.

I will take another guess: you are using an MS IDE, and the window closes right away?

There is a FAQ on that:

Cprogramming.com FAQ > Stop my Windows Console from disappearing everytime I run my program?


Quzah.

Originally Posted by cooldude

its not that iam lazy to do things...........
iam new to these forums and i thought it could be sufficient to solve my problem, so i did not quote the clear and exact problem description...........
its my mistake.........
but dont discourage the people who are willling to learn new things by using adjectives like worst,bad etc..............
and moreover u can advise people in a much comfortable way............
and during our communication , if anything hurts u , then Iam sorry................

Did you know that there is no such word as "iam"? They are two separate words; "I" and "am". You're certainly not lazy when it comes to adding extra dots at the end of sentences. Overzealous is perhaps what I'd call it.
My advice to you is to try and write propper English. It will go a long way towards getting people to take you seriously. That means capital letters at the start of sentences, no extra dots, comma has a space after it but not before, the word"I" is always capital, lots of stuff like that.
We now have a baseline of how you wrote stuff today. If you show that you're making an effort to write readable sentences next time, then more people will feel like making an effort to help, and they'll do it more politely too! It's all for your own bennefit.

Originally Posted by iMalc

write propper English.

[sic] .............