When I try to cocatenate a character in a buffer to my string, or character array, it gives me the warning. IT is the line where I am using strcat()
fdump.c:57: warning: initialization makes pointer from integer without a cast
here is a snippet of my code that uses this function
str is a char array
and buffer is a buffer.
insertCode:for (i=0; i<bytesRead; i++) { if (19<buffer[i]<127]{ printf["."]; } else{ printf("%s ", buffer[i]); } strcat(str,buffer[i]); bytesPrinted++;
> printf["."];
How does this even compile?
And how did you declare str and buffer ?
buffer[i] sounds like a single char, in which case there are several more mess-ups to deal with as well.
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
Did you include string.h? Otherwise, is "buffer" a character array? If so, you're doing it wrong. Also, your if check is wrong.
Quzah.
Hope is the first step on the road to disappointment.
printf["."] doesn't make any sense. strcat(str, buffer[i]) also doesn't make any sense, since you can only add a string to a string and buffer[i] is not a string but a single character. If you need to add a single character to str, then you probably want to do something like
and then make sure at the end that str is null-terminated.Code:str[some_appropriate_number] = buffer[i]
Trust me it makes sense in my code.Originally Posted by tabstop
And thanks for the help!!
If you refer to printing the period, I can only hope that your code actually looks like
instead of what you posted here.Code:printf(".");
I'm guessing they were referring to the buffer[ i ] statement.It's possible they really did mean ... buffer[ i ].Code:char foo[BAR]; char *baz[BAR]; ... strcat( foo, baz[ i ] );
Quzah.
Hope is the first step on the road to disappointment.
Then I wish them the best of luck with finding a pointer between 19 and 127.
Anyway given that the parenthesis in the if statement also mysteriously turned into a bracket I'm guessing it's someone who thinks re-typing the code and introducing strange new errors is cool and cutting-and-pasting the actual code is for losers.
You mean like this?Something like that?Code:char *buf[ 128 ]; size_t x = 0; for( x = 0; x < 128; x++ ) { buf[ x ] = malloc( 128 ); sprintf( buf, "hello number %d!\n", x ); } ...on to their code... strcat( foo, buf[ x ] );But no, I don't know what they're really meaning to do there either.
Quzah.
Hope is the first step on the road to disappointment.
It never ceases to amaze me how little pertinent information is included in some of these posts. I try to resist the temptation to make references to crystal balls or charades...it's difficult, though.
There's your problem right there. You cant use strcat to concatenate a string and a character. You can use it to concatenate a null-terminated string of only one character onto another null-terminated string though. You need to make a null-terminated string of one character somewhere to use strcat.
You'll get a warning on the printf line too where you're making the same mistake. However , unlike strcat, printf can be used to print a single character, but you need a different format specifier for that: "%c".
Don't ask us to trust you, you don't have a clue what you're doing. Tis you who should trust us.
My homepage
Advice: Take only as directed - If symptoms persist, please see your debugger
Linus Torvalds: "But it clearly is the only right way. The fact that everybody else does it some other way only means that they are wrong"
