Thread: Not accessing my pointers correctly?

I have written this bit of code

Code:

char *mystrcpy(char * s1, const char * s2)
{
  //Copies s2 into s1, including the null terminating character
  int tick = 0;
  while(*s2[tick] != 0)
  {
	  *s1[tick] = *s2[tick];
	  tick++;
  }
  *s1[tick] = *s2[tick];
  return s1;
}

And I am getting this error when ever I deal with my pointers:
invalid type argument of `unary *'

I cant find anything wrong with it.

Think of it this way:

- s1 is an address (pointer).
- *s1 is the value at that address. You could also write that as *( s1 + 0 )
- s1[ 0 ] is the same as *( s1 + 0 )
- s1[ 1 ] is the same as *( s1 + 1 )

So obviously *s[ 0 ] is trying to dereference a value (not a pointer), which of course, does not make sense.

so are you saying that s[x] is already dereferencing the pointer?

Right, it basically means "add ( x * sizeof( char ) ) to the base address 's' and dereference. It follows then that:

( s + 0 ) == s
&s[ 0 ] == ( s + 0 )

...etc...

Thanks for all of your help guys.