Segmentation fault why, adn general functionality problems

[cloudsword]

So I have this code, and its giving me problems. In the first line of output, it displays how I want it to, after which it screws up. It's supposed to display 16 characters, then those 16 characters in hex. Oh by the way, I am using Linux.

#include <unistd.h> 
#include <sys/stat.h>
#include <fcntl.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>
int main(int argc, char** argv) {
int fd;
size_t linesize=16;
int i=0;
char buffer[4096];
ssize_t bytesRead;
ssize_t bytesPrinted=0;
char str[linesize+1];
int j;
fd=open(fd, O_RDONLY, 0);
	while ((bytesRead = read(fd, buffer, 4096)) > 0){
	for (i=0; i<bytesRead; i++) {
		if (buffer[i]=='\0'){
			exit(0);
		}
		else{
			printf("%c ", buffer[i]);
			str[i]=buffer[i];
			bytesPrinted++;
			begin++;
			if (bytesPrinted % linesize == 0){
				str[linesize]='\0';
				for (j=0; j<linesize; j++){
					printf("%2x ", str[j]);
				}
			str[0]='\0';
			printf("\n");
			}
		}		
	}
}
return 0:
};

Oh by the way
sorry about misspelling and
my fingers got ahead of me.

[tabstop]

I'm not a fan of your open statement.

But anyway, once i goes past 16 all hell will break loose, since str[i] will no longer exist.

[quzah]

Is there any particular reason you're using open and read instead of fopen and one of the other reading functions?


Quzah.

[cloudsword]

wouldn't the str[0]=''\0' take care of that problem?

[tabstop]

wouldn't the str[0]=''\0' take care of that problem?

No, and I'm not sure why you think it would.

[cloudsword]

Well, doesn't that function clear your string?

[tabstop]

Well, doesn't that function clear your string?

Yes. Since that's not related to your problem (your problem being i is way too big) so what?

[cloudsword]

No, and I'm not sure why you think it would.

thus making your string ready for another set of 16 chars?

[tabstop]

thus making your string ready for another set of 16 chars?

Yes. So you would have to make even a slight attempt at putting 16 more chars in the string, as opposed to what you are doing in your code. (No seriously: read your code and don't just think it does what you want it to do.)

[Elysia]

Remember that a buffer only has so much storage. If you bought 16 apples, you wouldn't try to eat 17 apples.

[cloudsword]

Yes. So you would have to make even a slight attempt at putting 16 more chars in the string, as opposed to what you are doing in your code. (No seriously: read your code and don't just think it does what you want it to do.)

Thanks, After getting away from my computer, it came to me that I needed to replace i with something like bytesread%linesize;

[MK27]

If you bought 16 apples, you wouldn't try to eat 17 apples.

There is nothing wrong with trying

No matter what you use to replace i, just make sure it is never >16. bytesread%linesize looks good.

[Elysia]

There is nothing wrong with trying

Sure, but you will fail miserably, just as you hopefully will by writing more data into a buffer than there is space.