Thread: comparing strings/arrays

Hello,

I normally program embedded devices in ASM and my boss asked me to fix some code that was written in C, I have done a little C but not to much.

The problem I've noticed is that a comparison doesn't always return true.

We have an array of characters UBconfigData.code2[16] and we have a constant

Code:

#define VERSION			"2.10"
#define ScaleType			"47 "
#define ScaleVer			ScaleType VERSION

when these two get compared sometimes true is return and sometimes it is not.

Code:

strcmp(UBconfigData.code2, ScaleVer )

UBconfigData.code2 is set by this method

Code:

strcpy(configData.code2,ScaleVer); //Update code1,2 to current version

I'm wondering does strcmp stop at the termination or does it continue to the end of the array?
Should I do a memcmp and memcpy?

Ron

strcmp does stop at the terminating \0 character at the end of a string. The thing to note is that "47 " "2.10" is one string (i.e., it is the same as "47 2.10"), so it's not as though you're getting cut off halfway. Is it possible that the strcmp is getting called before the strcpy? (Also, notice that if the two strings are the same, strcmp will return 0.)

Yes I know this but I only care if they match or not.

Code:

if (strcmp(UBconfigData.code2, ScaleVer ) !=0) 
{
     version changed
}
else
{
    no change
}

with it being intermittent I figure I'm doing the check with the wrong function.

Ron