Thread: Having problems initialising a 2d array which is part of a struct

Hi all, I am having a little bit of difficulty initialising a 2d array, for a player of type struct.

I've created a struct to represent a player, and created two players of this struct type, as so:

Code:

struct player
    { 
        int scoreC, scoreT, startScore, numDarts, legs, sets;
        int scoreCC[2][8];
        float dartAve;
        char name[15];
    };

    struct player player1, player2;

I have created a 2d array to represent their score (the zeros will be updated as the game progresses):

Code:

player1.scoreCC[2][8] = {15,16,17,18,19,20,25,50,
                         0, 0, 0, 0, 0, 0, 0, 0};

However the compiler just says "parse error before '{' token" which isn't giving me much to go on really. I have tried doing it for a 2d integer array that isn't part of a struct and it works fine:

Code:

int scoreCC[2][8] = {15,16,17,18,19,20,25,50,
                     0, 0, 0, 0, 0, 0, 0, 0};

What am I doing wrong? I haven't been doing C for very long so I presume I'm making some silly error.

Even with a "free-standing" array, you can't initialize it's elements that way after it's been defined. You need to initialize it (as well as the other members) when the structure is instantiated, eg:

Code:

struct player player1 = 
{
    0, // scoreT 
    0, // startScore
    0, // numDarts
    0, // legs
    0, // sets
    {
        15,
        16,
        17,
        18,
        19,
        20,
        25,
        50,
        0, 
        0, 
        0, 
        0, 
        0, 
        0, 
        0, 
        0
    }, // scoreCC
    0.0, //dartAve
    "Joe" // name
};

Originally Posted by Sebastiani

Even with a "free-standing" array, you can't initialize it's elements that way after it's been defined. You need to initialize it (as well as the other members) when the structure is instantiated, eg:

Code:

<snip>

I see.

I have done this in other parts of the program before the 2d array was present (as shown below), and there was never a problem. Or do I now have to change the way in which i instantiate the variables because of the addition of the 2d array?

Code:

printf("\nHow many people are playing?: ");
    scanf("%d", &numPlayers);
    
    struct player player[numPlayers];
    
    for (i = 0; i < numPlayers; i++) 
    {
        printf("\nPlayer name: ", i);
        scanf("%s%c", &player[i].name, &x1);
        player[i].startScore = gameType;
        player[i].scoreC = player[i].startScore;
        player[i].numDarts = 0;
        player[i].scoreT = 0;
        player[i].dartAve = 0;
        player[i].sets = 0;
        player[i].legs = 0;
    }

No, it's perfectly fine (and usually more convenient) to perform the initialization later (often using a "set" function). And one more thing, the example I posted was not actually correct. Since the array is two-dimensional, the initialization would have been:

Code:

struct player player1 = 
{
    0, // scoreT 
    0, // startScore
    0, // numDarts
    0, // legs
    0, // sets
    {
        {
		15,
        	16,
        	17,
        	18,
        	19,
        	20,
        	25,
        	50
	},	
        {
		0, 
        	0, 
        	0, 
        	0, 
        	0, 
        	0, 
        	0, 
        	0
	}	
    }, // scoreCC
    0.0, //dartAve
    "Joe" // name
};

Ok thanks, so just for my understanding, why can I not initialise the 2d array in the same way as the other struct variables? As per your code example, I have to change the whole way in which I am initialising my player variables because of the introduction of a 2d array? Or am I not understanding it?

Good stuff.

Thanks for your help guys