passing arg 1 of 'strlen' makes pointer from integer without a cast

[ChoCo]

Does anyone know, why a warning come up when I run this?
Warnings are the lines with red color.
How can I fix this warning, please help...

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define MAX 30

int main()
{
    int customerCount=0;
    char input[32];
    char drinks[MAX][10];
    char size[MAX][6];
    char hotCold[MAX][5];
    int i=0;

    printf("How many people are at your table?: ");
    fgets(input,32,stdin);
    sscanf(input,"%d",&customerCount);

    if(customerCount==0)
        {
            printf("END");
            exit(0);
            /*summary*/
        }

    printf("Choose what type of drink would you like.\n");

    while(strcmp(drinks[i],"None")!=0)
        do
        {
            printf("Coffee, Tea, Cocoa, or Ovaltine?: ");
            fgets(input,32,stdin);
            sscanf(input,"%s",drinks[i]);
        }
        while(strlen(drinks[i]==0));

        do
        {
            printf("Small or Large?: ");
            fgets(input,32,stdin);
            sscanf(input,"%s",size);
        }
        while(strlen(size==0));

        do
        {
            printf("Hot or Cold?: ");
            fgets(input,32,stdin);
            sscanf(input,"%s",hotCold);
        }
        while(strlen(hotCold==0));
}

[bithub]

while(strlen(drinks[i]==0));

should be

while(strlen(drinks[i])==0);

The other while() statements have the same problem.

[Elysia]

Let's dissect this:
while(strlen(drinks[i]==0));

while(
strlen(drinks[i]==0)
);

while(
strlen(
drinks[i]==0
)
);

So essentially, you're comparing drinks[i] to 0 (ie is it a NULL pointer?), which gives true or false, and that is passed to strlen. Oops.

[bithub]

Some other issues with your code:

sscanf(input,"%s",size);
...
sscanf(input,"%s",hotCold);

You can't copy a string into a 2D char array.

Also 2 of your while loops attempt to treat a 2D char array as a string (they are passed to strlen()).

[ChoCo]

Thanks a lot
I've already make the change
but when i run the program,
it keeps asking what's in the loop eventhough i type in sth
did i do anything wrong???

[bithub]

You told it to loop until the user enters in the text, "None".

[ChoCo]

i mean the small loop of strlen
eventhough i type in sth, it still loops

[bithub]

No it doesn't. It loops because of this line:

while(strcmp(drinks[i],"None")!=0)

Look at your code:

    while(strcmp(drinks[i],"None")!=0)
        do
        {
            printf("Coffee, Tea, Cocoa, or Ovaltine?: ");
            fgets(input,32,stdin);
            sscanf(input,"%s",drinks[i]);
        }
        while(strlen(drinks[i]==0));

The first loops says, "While drinks[i] doesn't equal 'None'"...
The second loops says, "Get user input while drinks[i] is of zero length".
If you type in anything other than the text, "None", it will continue looping.

[ChoCo]

i see...
is there a way to fix this?
the program want to ask the type of drink until None
but if the user type nothing, i want it to ask again.

[bithub]

i see...
is there a way to fix this?
the program want to ask the type of drink until None
but if the user type nothing, i want it to ask again.

That's exactly what it is doing...
It will loop until the user types in "None". Maybe I don't understand what it is you are asking...

[ChoCo]

I mean it already loop until None already
but I also want to check if the user doesn't type anything, the program should ask again
and if the user type in sth but it's not None, the program should proceed to the next operation

[bithub]

Then you probably want something more like:

while(1)
{
    do
    {
        get drink type
    }
    while(drink type length > 0);

    if(drink type is "None")
        break; // break out of the main loop

   get the size, and hot/cold down here
}

[Elysia]

Use a flowchart. You should not have to ask this because the solution is in your mind.

[ChoCo]

Sorry to ask a lot, because i'm very new to c programming
can you explain,
1. what is while(1)?
2. why do you use

while(drink type length > 0);

to loop?

[MK27]

fgets() will include a \n in the input string, so the strcmp will never succeed:

"None" != "None\n"

Use strncmp() for this instead:

while(strcmp(drinks[i],"None",4)!=0)

ps. while(1) is an infinite loop -- (1) is always true. You must use break, return, or exit to end the loop.