trying to remove " off end of string

[Tigers!]

Gudday
Still trying to catch up C programming after no activity for a decade.
I want to strip a trailing " off a string so that the string can be used to move a file but the program is crashing
The string in question (known as tiffUrl) looks like

\\Au-mobius-e\E20-120_Scan\PICKLIST\0000544A.TIF"

The " at the end is the problem.
I thought that copying the string, except for the last char (the ") would do the trick but alas it does not work

char *tiffUrl="";   //string contains where TIFF file will end up
char *tmp="";     //temporary holder to remove trailing " in tiffUrl

....

tiffUrl= (fileline + strlen(fileline) - (strlen(fileline)-index));
printf("Length of tiffUrl is %i\n", strlen(tiffUrl));
for(x=0;x<(strlen(tiffUrl)-1);x++) {
   printf("x=%i\n", x);
   tmp[x] = tiffUrl[x];
}
printf("new tiffUrl is %s\n", tmp);

The code prints out x =0 ok then crashes.

[once I get the code working I was going to copy tmp back to tiffUrl using

tiffUrl = tmp;

Is this ok or should I do use strcpy?

[bithub]

I couldn't quite follow what you were doing in that code, but is this what you are looking for?

char string[] = "\\Au-mobius-e\E20-120_Scan\PICKLIST\0000544A.TIF\""
size_t length = strlen(string);
if(string[length-1] == '\"') /* If the last character is a quote... */
    string[length-1] = '\0';  /* Remove the last character */

[Tigers!]

Sorry I made it so obtuse.

I know that the file will have the " at the end. There is previous work that is unseen that makes it happen.
As long as I can shorten the file by one (1) character, the ", then i will be happy.

I will try your as it appears simpler that my effort.;

[bithub]

If you are just shortening a string by chopping off the last character, then it can be simplified down to:

string[strlen(string)-1] = '\0';

[Tigers!]

Wouldn't it be strlen-2 rather than strlen-1?

When I tried strlen-1 it appears to have trouble i.e no change in tiffUrl. When I try strlen-2 the " disappears. I assume that is because the new line character was strlen-1. I note that now the list of strings (more that one tiffUrl is being generated) when printed to a file are one contiguous string rather than being on a separate line as usual.

Sign. Fix one problem and another appears.

[tabstop]

If you refer to the filenames being printed out one after the other, that indicates that your printf statement is incorrect. (If you want your file names separated by something, you must print that something out yourself instead of expecting it to magically happen.)

[bithub]

Wouldn't it be strlen-2 rather than strlen-1?

Only if you want to chop off the last 2 characters in the string instead of the last 1.

[Sebastiani]

Another simple way to do it:

char* quote = strstr( data, "\"" );
if( quote )
	*quote = 0;

[laserlight]

I suggest strchr instead of strstr, or possibly strrchr if there may be quote characters in the middle of the string that should remain. (But if there may be such characters in the middle of the string, and yet there might not be such a character at the end to remove, then the strlen method would be correct.)

[Sebastiani]

>> I suggest strchr instead of strstr, or possibly strrchr if there may be quote characters in the middle of the string that should remain. (But if there may be such characters in the middle of the string, and yet there might not be such a character at the end to remove, then the strlen method would be correct.)

Good point.