Thread: srand rand. return always the same value

Hi

I wrote a funct my_random(limit) that 'should' return a pseudor-random value between 0 and limit-1, then I have a small prog like:

Code:

main_prog.c
..............
int random_value;
............. 
srand(time(NULL)); // 
          random_value= my_random(limit); // here I call my funct
....

where my_random looks like

Code:

int my_random(int val){

int rand_choice=0;
	rand_choice=rand()%(val);
        printf("%d\n",rand_choice);

return rand_choice;
}

the problem in that i get always the same value. I'm reading some tutorials and I know that is important to choice the right place where put the srand(seed).
But I belived that outside the function should be enough, otherwise where should be the right position?

Thanks
D

Code:

main_prog.c
..............
int random_value;
............. 
srand(time(NULL)); // 
          random_value= my_random(limit); // here I call my funct
....

Where did you declare ant initialize the variable limit?

In main_prog.c.

Limit is an input value.

..Try to put the srand() call as you wrote it, in the function as you don't use rand().

already done.
I've tried to put srand in:

-the function my_rand()----->but i still get the same values
-in the top of main but i get an error like:

Code:

main.c:52: error: expected ‘)’ before ‘(’ token
main.c: In function ‘create_new_outfiles’:
main.c:705: warning: ignoring return value of ‘system’, declared with attribute warn_unused_result
make[2]: *** [main.o] Error 1

Hi

I solved the error in the main and i wrote srand after the main, now it works

Thanks

D