reading from an file into into an array!

[doubty]

Hi I have a very very peculiar problem,

I am trying to read a file with data in the following format

1.0000 1 1 4 and storing into a 3d array as below:

     
    file1= fopen("C:/Gibb.txt","r");

	
    while(fscanf(file1,"%d %d %d %f",&filet,&filex,&filev,&filep)!=EOF)
	 {
                      brown[filex][filet][filev]=filep;
                      
          }
     
     
     fclose(file1);

the code compiles fine, but when running i get run time error after running some loops,

P.S: the data file is really huge and has about 20000 rows

[Salem]

How did you declare your array?

What ranges are filex etc, are they always in bounds (can you prove it?)

Also, != EOF should be better written as == 4

[tabstop]

"1.0000 1 1 4" and "%d %d %d %f" aren't really compatible.

[doubty]

float brown[32][99][5] ; is how i declared my array

ya the range of [filex] is 0-32
[filet] is 0-99
[filev] is 0-5

@tabstop, sorry typo, the format is ' 1 1 4 1.000000'

[tabstop]

If the range of filex is 0-32, and 0-99, and 0-5, then you had better be declaring your array as brown[33][100][6].

[doubty]

I tries this... but no avail.. still getting the same error

[tabstop]

You'll have to grin and bear it and tell us what the error actually is then I guess.

[Salem]

[filex] is 0-32
[filet] is 0-99
[filev] is 0-5

So add that to your code

if ( filex >= 0 && filex < 32 &&  and so on for t and v ) {
  brown[filex][filet][filev]=filep;
} else {
  fprintf( stderr, "OUT of range: %d %d %d\n", filex, filet, filev );
}

[doubty]

Hi,

I tried some debugging, it is reading the file perfectly and storing the same into an array , however in the end of the mian function when returning Iam getting the error!!!!

i.e "stack around brown was corrupted" please help

[Sebastiani]

>> i.e "stack around brown was corrupted" please help

Well, without seeing the code that you're using, it's impossible to say.

[doubty]

int main()
{
    char inputexp[500];
    FILE *file1;
    int filet,filex,filev;
    float filep;
    float brown[33][99][5];
    int count=0,new_count=0,g;
	clock_t start;

    file1= fopen("brown.txt","r");


    while(fscanf(file1,"%d %d %d %f",&filet,&filex,&filev,&filep)== 4)
	 {
                      brown[filex][filet][filev]=filep;
                    
     }
     
    
     fclose(file1);
   
   
   	printf("enter expression");
	scanf("%s",inputexp);
	

    strcpy(label[0],inputexp);
            
	
	start = clock();
	
	
     
  
    parser(label);
    

	 return 1;
          
  }

please help!

[Sebastiani]

1) You need to check the return value of fopen.
2) You need to implement bounds checking (see Salem's post). It might be helpful to print the values read from the file to verify that they are correct, as well.
3) I can't see how 'label' is declared, nor the code for 'parser', so I have no idea if they have anything to do with the error(s).

[doubty]

Hi,
i have declared label as a global function hence it is nt shown, also the function parser works fine ( coz the code executes w/o any issues when the file operations are not done) , also the function has nothig to do with the file i.e the function parses the input provided by the user.

I tried debug mode using an IDE, the file is opening, the contents are read fully and stored in an array, the file is closed, user is asked for the expression, the function is eveluated. return 1 is also executed, however after it reaches the last bracket and wants to stop the error is propped up.

however
Thanks

[Sebastiani]

>> however after it reaches the last bracket and wants to stop the error is propped up.


So why don't you post the updated code with the changes you've made?

[KBriggs]

try

double ***filep;
filep = (double ***) malloc(33 * sizeof(double **));
if (filep == NULL)
{ 
     printf("error in part 1\n");
     abort();
}
for (int i = 0; i < 33; i++)
{
    filep[i] = (double **) malloc(100 * sizeof(double *);
    if (filep[i] == NULL)
    { 
     printf("error allocating memory for filep[%d]\n",i);
     abort();
    }
}
for (i = 0; i < 33; i++)
{
     for (int j = 0; j < 100; j++)
     { 
          filep[i][j] = (double *) malloc(6 * sizeof(double));
          if (filep[i][j] == NULL)
          {
               printf("Error allocating filep[%d][%d]",i,j);
               abort();
          }
      }
}

I have had problems with passing arrays that are declared like you did before - might be completelt unrelated, but try mallocing it like that instead. Don't worry - you'll still be able to access array elements as you were before.

If an array like you declared earlier gets too big, passing it as a parameter to a function starts causing problems, or at least it did to me. If you can use malloc, do it ^_^. Don't forget to free it with more loops.