Thread: having some trouble calling a function in the main program

>> Im going to try to finish the current program since it seems like im having trouble even using the strtok function.

I don't understand. Other than the fact that it needed to be moved into the input loop, it looked fine.

>> char *parsed=NULL;

Still NULL.

Originally Posted by CMakesMeSad :(

I got it! Sort of. So the code below does this now:
Hello world
Hello
world

Which is exactly what I want the program to do but not the way it currently does it.

Code:

#include <stdio.h>
#include <string.h>
#define MAXLENGTH 256

char *next_word(char *instring, char **new_start);

int main()
{
	char instring[MAXLENGTH];
	char *words=NULL;
	char *parsed=NULL;

	printf("Enter the freaking text:\n");

	fgets(instring, MAXLENGTH, stdin);

	puts(instring);
	words=next_word(instring, &parsed);

	while (words != NULL)
	{
		printf("%s\n", words);
		words=next_word(parsed, &parsed);
	}
}

char *next_word(char *instring, char **new_start)
{
	new_start=strtok(instring, " ");
	//return instring;

}

If I uncomment "return instring" ill only get the first word outputted. Is there a way to make the function return NULL & instring?

Instead of returning instring, you should return new_string. Then I think it'll do it.

Kind of getting there. This code outputs the first word but it gets stuck in a looping cycle

Code:

#include <stdio.h>
#include <string.h>
#define MAXLENGTH 256
#define delimiter ""

char *next_word(char *instring, char **new_start);

int main ()
{
	char instring[MAXLENGTH];
	char *words=NULL;
	char *new_start=NULL;
	char *parsed=NULL;

	printf("Enter sentences:\n");

	fgets(instring, MAXLENGTH, stdin);

	words=next_word(instring, &new_start);

	while (words != NULL)
	{
		printf("%s\n", words);
		words=next_word(new_start, &new_start);
	}
	
	return 0;
}

char *next_word(char *instring, char **new_start)
{
	*new_start=strtok(instring, " ");
	return *new_start;


}

I was talking about just returning new_start in your previous code without any other changes in it. So it may look like this.

Code:

#include <stdio.h>
#include <string.h>
#define MAXLENGTH 256

char *next_word(char *instring, char **new_start);

int main()
{
	char instring[MAXLENGTH];
	char *words=NULL;
	char *parsed=NULL;

	printf("Enter the freaking text:\n");

	fgets(instring, MAXLENGTH, stdin);

	puts(instring);
	words=next_word(instring, &parsed);

	while (words != NULL)
	{
		printf("%s\n", words);
		words=next_word(parsed, &parsed);
	}
}

char *next_word(char *instring, char **new_start)
{
	new_start=strtok(instring, " ");
	return new_start;//just a change here

}

[edit]
In your last code except for the first time, instring gets replaced by "hello"(in case of hello world) in the function and that's why new_start points to "h" each and everytime when calling the function, that's why it gets stuck in the loop.
[/edit]