string genrator

[elwad]

problem here it everytime it keeps genreting more and more not just the much as specify i want to genrate only i dunno whats problem here :S

#include <stdio.h>
#include <time.h>
#include <string.h>
#include <stdlib.h>
void string_genrator(char *buffer,int N)
{
	
	int c;
	size_t i;
	srand(time(NULL));
	for(i = 0; i < N; i++) {
		c = 'a' + rand() % ('z' - 'a' + 1);
		buffer[i] = c;
	}
	buffer[i]=0;
	i++;
}
int main(void)
{
    char in[100];
    char buffer[]="name";
    srand(time(NULL));
    for(;;) {
        string_genrator(in,4);
        strcat(buffer,in);
        printf("Okay thats buffer <<%s>> ",buffer);
        getchar();
        }
    return 0;
}

[MK27]

problem here it everytime it keeps genreting more and more not just the much as specify i want to genrate only i dunno whats problem

English. Clear, comprehensible English. What exactly is your packet sniff showing?

You could at least try a little bit.

[elwad]

oh i see it keeps adding to old buffer

[elwad]

but how can i fix this should i just null terminate it and assign it again ?

[anon]

1) You keep concatenating the random 4-letter string onto the buffer.

2) Said buffer doesn't have any room to append anything to it. char buffer[] = "test" means that you have an array of 5 characters (including the terminating 0) to play with.

[elwad]

yah i figured but should i add 0 terminator then before that save that name to another array then resiagn back at the start of the loop or is there better way to do it ?

[matsp]

Ehm, you need to reserve enough space to store the final string. Since your buffer is already full when it contain "name", it can't be added to without overwrting something.

It is not clear what you are actually trying to do, but having an infinite loop adding to a buffer will pretty quickly run out of memory [ok, maybe not so quickly if you keep printing the string].

--
Mats

[elwad]

i did del then rewrote it again

#include <stdio.h>
#include <time.h>
#include <string.h>
#include <stdlib.h>
void string_genrator(char *buffer,int N)
{
	
	int c;
	size_t i;
	srand(time(NULL));
	for(i = 0; i < N; i++) {
		c = 'a' + rand() % ('z' - 'a' + 1);
		buffer[i] = c;
	}
	buffer[i]=0;
	i++;
}
int main(void)
{
    char in[100];
    char buffer[]="name";
    int i=0;
    srand(time(NULL));
    for(;;) {
        if(i>0)
            strcpy(buffer,"name");
        string_genrator(in,4);
        strcat(buffer,in);
        printf("Okay thats buffer <<%s>> ",buffer);
        getchar();
        buffer[0]=0;
        i++;
        }
    return 0;
}

[matsp]

Your buffer still only has space for 5 characters, which you stuff in there with the "name" you assign in the first place. Adding another four characters makes 9, which overwrites whatever else is after the string.

        buffer[0]=0;

is completely meaningless, as you soon after will set the string with strcpy(buffer, "name");

--
Mats

[elwad]

i made it name[10] so it doesnt overwrite but should if when i strcpy it shouldnt it get buff over flow ?

[matsp]

i made it name[10] so it doesnt overwrite but should if when i strcpy it shouldnt it get buff over flow ?

Not sure what you are trying to say here. name[10] will be fine for what you have been doing [in fact, it's one char too long, but that's just being very pedantic].

If you your reference to strcpy you are trying to say that if you copy a 5 character string (including the terminating zero) into a 10 char array without first initializing the string, it would somehow cause a problem, then no, it doesn't. strcpy SETS the string to whatever is in the second argument.

--
Mats

[elwad]

yah i was asking abt strcpy anyways thanks alot