I have an interesting problem here. The function returns the first cell of a local array, so I am getting this: returning address of local variable or temporary. How can I return a new string without this message?
Code:const char *X3DConsole_GetTitle() { char strTitle[80]; GetConsoleTitle(strTitle, 80); return strTitle; }
One way would be to allocate "strTitle" on the heap instead of on the stack.
Good idea. I changed my code to the following. If I'm using malloc, I'd have to call free though. I'd like to do it within the function so I'm not calling free() outside of it.
Another solution is to make strTitle a static local variable. I'm not sure if this is a good solution though.
Code:const char *X3DConsole_GetTitle() { char *strTitle = NULL; strTitle = (char *)malloc(sizeof(char) * 80); GetConsoleTitle(strTitle, 80); return strTitle; }
If you're not changing "strTitle" in the calling function, then you can call free() in there too.Originally Posted by philvaira
That would work just fine.
Last edited by itCbitC; 05-25-2009 at 01:06 AM.
I'll stick with the static solution since it is a little cleaner. Thanks
Actually, my preferred solution is to pass in an already existing array to store the string in. You should then also pass in a size, so that you can deal with "it may not fit" problems.
The benefit of passing it into the function is that the calling function can decide where to put it, and there is no reason to copy the string again to get it into it's final destionation - e.g. you want to store it into a struct, then that would work better by calling:
The static solution is not very flexible, the temptation is to store the pointer directly - in which case the content will change "behind the scenes" if you call the function again [assuming it doesn't always return the same thing!]. It also goes to pot if you start using threads.Code:X3DConsole_GetTitle(mystruct.title, sizeof(mystruct.title));
--
Mats
Compilers can produce warnings - make the compiler programmers happy: Use them!
Please don't PM me for help - and no, I don't do help over instant messengers.
ITA with matsp since the purpose of static variables is to retain their values between function calls instead of communicating data between functions.
