The progam is to count the number of lines, when i punch hash the program doesnt terminate, if anybody can point put my mistake.
Code:#include<stdio.h> #include<conio.h> void main() { int c, n1; clrscr(); n1=0; while ((c==getchar()) != '#' ) if (c=='\n'); ++n1; printf("%d\n",n1); getch(); }
Well there's the whole 'void main' thing, see the FAQ (and other things)
> while ((c==getchar()) != '#' )
How many comparisons?
> if (c=='\n');
How many statements does this if statement guard?
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
There are some small mistakes. You have many syntax errors.
EDIT: Salem was faster. Look at his avatar, it will help
return 0 from main means everything is done, there were no severe errors. Anything else means the program didn't do its jobproperly (because of a bug, environment etc.)Code:#include<stdio.h> #include<conio.h> int main() /* It's int! Arrggh! */ { int c, n1 = 0; /* Why not initialize n1 to zero? */ clrscr(); while ((c = getchar()) != '#' && c != EOF) /* ASSIGN c to getchar() and also stop at end of input */ if (c == '\n') /* No semicolon here */ ++n1; printf("%d\n",n1); getch(); return 0; /* Here, see why it's int? */ }
Last edited by Brafil; 05-17-2009 at 03:24 AM.
use = instead of == in your while statementOriginally Posted by Fatima Rizwan
your if statement is terminated by the semicolon and does nothing
void main is bad
Edit: awww too slow
╔╗╔══╦╗
║║║╔╗║║
║╚╣╚╝║╚╗
╚═╩══╩═╝
