Thread: why the score1 and score2 variables exceed the maximum value of 50?

Originally Posted by tadeboro

Hello.
Actually, this depends. For example, if score1 is 45 before the last dice throw and you get two 6, the final score will be 70.

Okay. This would seem a slightly different issue (from the one whereby no one could win until both players top 50).

Originally Posted by tadeboro

Hello.
Actually, this depends. For example, if score1 is 45 before the last dice throw and you get two 6, the final score will be 70.

And to solve that, you need to add a check that validates the total value is still under 51 - or say "bust" or whatever.

--
Mats

I don't know exactly what you the rules for the game is. But if we assume that the rules are "if the sum gets above 50, no score", then something like this:

Code:

int throwscore = 0;
...
if (dice1 == dice2)
{
   ...
   if (dice1 == 6)
       throw_score = 25;
   else
      throw_score = 5;
   if (score1 + throw_score <= 50)
      score1 += throw_score;
}

You may need to adjust this to match your actual scoring rules, but something like that.

--
Mats

Final run:

Code:

#include <stdio.h>
#include <stdlib.h>
#include <time.h>

int main(void)
{
	int die1, die2, score1, score2, throwscore;
	srand((unsigned)time(NULL));

	die1 = die2 = score1 = score2 = throwscore = 0;

	while(score1 < 50 && score2 < 50)
	{	
		//player 1
		die1 = (rand()%6)+1;
		die2 = (rand()%6)+1;
		
		if(die1 == die2)
		{
			printf("Player 1 scored double %d\n", die1);
			if(die1 == 3)
				throwscore = score1 = 0;
			else if(die1 == 6)
				throwscore = 25;
			else
				throwscore = 5;

			if(score1 + throwscore <= 50)
				score1 += throwscore;

			printf("Player 1 = %d\n", score1);
		}
		
		//player 2
		die1 = (rand()%6)+1;
		die2 = (rand()%6)+1;
		if(die1 == die2)
		{
			printf("Player 2 scored double %d\n", die1);
			if(die1 == 3)
				throwscore = score2 = 0;
			else if(die2 == 6)
				throwscore = 25;
			else
				throwscore = 5;

			if(score2 + throwscore <= 50)
				score2 += throwscore;

			printf("Player 2 = %d\n", score2);
		}
	}
	if(score1 == score2)
		printf("Game is a tie\n");
	else if(score1 > score2)
		printf("Player 1 Wins\n");
	else
		printf("Player 2 Wins\n");

	return 0;
}

It works! Thanks matsp, you cleared my ideas! =)