Problem in a function

[elwad]

I m trying to code a indention fixer that will first after every 4 loop will add 4 spaces this just the base i m trying to figure out if i found a for then i will read it then jump to next line to add 4 spaces but problem is how can i jump to next line to add the 4 spaces ?? anyways here a code whish i m sure doesnt work Please any ideas how can if i found strsr for for and read it till 0 i wanna jump to next line to add 4 spaces how can i jump to it ? anyways here is current code

int search_it(char *buffer)
{
     int i;
	 for(i=0;buffer[i]!=0;i++){
		 if(buffer[i]=='{')
			 return 1;
		 else
			 return 0;
	 }
}
void canctnateit(char *buffer,char *buffer1)
{
     strcpy(buffer1,"    ");
     strcat(buffer1,buffer);
     strcpy(buffer,buffer1);
}
void indenter_fixer(char *buffer)
{
     int i,x=0;
	 char *search;
	 char buffer1[100];
     for(i=0;buffer[i]!='\0';i++){
		 if(strstr(buffer,"for")&& search_it(buffer))
		 {
			 MessageBox(NULL,"cool we found it","Founder",MB_OK);
			 x++;
			 if(x==1){
				 x=0;
				 canctnateit(buffer,buffer1);}
		 }
	 }
}

[MK27]

If "buffer" contains multiple lines it will contain a '\n' between them; if not it is up to you how to read the next line in.

[elwad]

i tried but program crashed after i puted buffer

void indenter_fixer(char *buffer)
{
     int i,x;
	 char *search;
     for(i=0;buffer[i]!='\0';i++){
		 if(strstr(buffer,"for"))
			 search_it(buffer);
	 }
}
int search_it(char *buffer)
{
     int i;
	 char buffer1[100];
	 for(i=0;buffer[i]!=0;i++){
		 if(buffer[i]=='\n'){
			 canctnateit(buffer,buffer1);
		 }
	 }
	puts(buffer); //this code here make it crash << 
}
void canctnateit(char *buffer,char *buffer1)
{
     strcpy(buffer1,"    ");
     strcat(buffer1,buffer);
     strcpy(buffer,buffer1);
}

[elwad]

this is weird i tried a function it works and doesnt work so weird for example this code

#include <stdio.h>
#include <string.h>
#define DEL_IT(P,N)P[N]=0
void copy_it(char *buffer,char *save_it,int num)//num will be the i
{
     int i,x;
     for(i=num,x=0;save_it[x]=buffer[i];i++,x++);
}
int main(void)
{
    char name[]="dude\nhell";
    char buffer[100];
    int i;
    for(i=0;name[i]!=0;i++){
        if(name[i]=='\n')
        {
            copy_it(name,buffer,i);
            DEL_IT(name,i);
            strcat(name,"    ");
            strcat(name,buffer);
        }
    }
    puts(name);
    puts(buffer);
    getchar();
    return 0;
}

doesnt work
but this does

#include <stdio.h>
#include <string.h>
#define DEL_IT(P,N)P[N]=0
void copy_it(char *buffer,char *save_it,int num)//num will be the i
{
     int i,x;
     for(i=num,x=0;save_it[x]=buffer[i];i++,x++);
}
int main(void)
{
    char name[]="dude\nhell";
    char buffer[100];
    int i;
    for(i=0;name[i]!=0;i++){
        if(name[i]=='\n')
        {
            copy_it(name,buffer,i);
            DEL_IT(name,i);
            strcat(name,"    ");
            strcat(name,"HELL");
        }
    }
    puts(name);
    puts(buffer);
    getchar();
    return 0;
}

wat the hell is wrong ????

[quzah]

An incomplete array is defined as having the exact number of members you've given it at the time of declaration. Since this is a character array initialized with a string, it's ending up with exactly 10 characters.

You are trying to copy 14 characters into it. That's bad.


Quzah.

[elwad]

so how can i fix in order that i wanna add at the next line of the for loop 4 spaces?

[quzah]

Stop using an incomplete array, and give it an actual larger size?

Quzah.

[elwad]

why then when i added HELL it worked? and i did give it a larger size now it did same thing compiled then exited

[quzah]

You got lucky. Neither one of them should work. I didn't see you adding four spaces in on the second one. But no, neither one of them are correct.


Quzah.

[elwad]

okay look i added here larger size of the array and it still didnt work i m compiling with gcc

#include <stdio.h>
#include <string.h>
#define DEL_IT(P,N)P[N]=0
void copy_it(char *buffer,char *save_it,int num)//num will be the i
{
     int i,x;
     for(i=num,x=0;save_it[x]=buffer[i];i++,x++);
}
int main(void)
{
    char name[40]="dude\nhell";
    char buffer[100];
    int i;
    for(i=0;name[i]!=0;i++){
        if(name[i]=='\n')
        {
            copy_it(name,buffer,i);
            DEL_IT(name,i);
            strcat(name,"    ");
            strcat(name,buffer);
        }
    }
    puts(name);
    puts(buffer);
    getchar();
    return 0;
}

[quzah]

You aren't skipping the newline. You're copying it into the string over and over again, while you're appending the other words.


Quzah.

[elwad]

oh yahhh thanks dude ...would have noticed it should i just increment name[i+1] ?

[elwad]

finally fixed it lol

#include <stdio.h>
#include <string.h>
#define DEL_IT(P,N)P[N]=0
void copy_it(char *buffer,char *save_it,int num)//num will be the i
{
     int i,x;
     for(i=num,x=0;save_it[x]=buffer[i];i++,x++);
}
int main(void)
{
    char name[40]="dude\nhell";
    char buffer[100];
    int i;
    for(i=0;name[i]!=0;i++){
        if(name[i]=='\n')
        {
            i++;
            copy_it(name,buffer,i);
            DEL_IT(name,i);
            strcat(name,"    ");
            strcat(name,buffer);
        }
    }
    puts(name);
    getchar();
    return 0;
}

[elwad]

thanks dude for the help