Is there anything wrong with this code?

**rightbrainer** · 04-22-2009

Code:

#include <stdio.h>
#include <stdlib.h>

int main(int argc, char *argv[])
{
int inches, centimeters=2;
printf("Enter inches: ");
scanf("%d, &inches");
printf("%d inches equals %d centimeters", inches, centimeters);

  return 0;
}

I can't find anything wrong with it, but it doesn't work..?

**laserlight** · 04-22-2009

Look carefully at this line:

Code:

scanf("%d, &inches");

**rightbrainer** · 04-22-2009

Ah! Ok got it. Next step. Why isn't the math working now?

Code:

#include <stdio.h>
#include <stdlib.h>

int main(int argc, char *argv[])
{
float inches, centimeters=2.54;
printf("Enter inches: ");
scanf("%f", &inches);
printf("%.2f inches equals %.2f centimeters", inches, centimeters, inches*centimeters);

  return 0;
}

When I type in 3 inches, it should say 7.62 centimeters, yet it only says 2.54

**laserlight** · 04-22-2009

Notice that your format string has two format specifiers but you provide three arguments to be formatted and printed.

**rightbrainer** · 04-22-2009

Ok that made me think. Thank you

Ok so I re-thought my solution and I changed it to:

Code:

#include <stdio.h>
#include <stdlib.h>

int main(int argc, char *argv[])
{
float inches, centimeters;
printf("Enter inches: ");
scanf("%f", &inches);
centimeters=inches*2.54;
printf("%.2f inches equals %.2f centimeters",inches, centimeters);

  return 0;
}

And it works!

For my reference, can you tell me how else this could be written if I declared the variables like this:

Code:

float inches, centimeters=2.54

**hk_mp5kpdw** · 04-22-2009

Code:

printf("%.2f inches equals %.2f centimeters", inches, inches*centimeters);

**rightbrainer** · 04-22-2009

Ah I was SO close.

I had it:

printf("%.2f inches equals %.2f centimeters", inches, centimeters, inches*centimeters);

but now I see why that does not work.

Thanks all!!

**matsp** · 04-23-2009

And if you do that sort of thing, it shoudl be

Code:

const float centimeters = 2.54f;

--
Mats

Thread: Is there anything wrong with this code?

Thread Tools

Search Thread

Display

Is there anything wrong with this code?

Similar Threads

what is wrong in this simple code

what is wrong with this code please

I cant find what is wrong with this code

Anyone see what is wrong with this code?

very simple code, please check to see whats wrong