Thread: Whats wrong?

Originally Posted by $l4xklynx

I see, but why put fgets as an expression in the if condition?



yes they can but it's wrong in C, that's what I meant... But in his program I don't think that he needs to initialize the array.

No its not wrong in C, and I always initialize my string arrays just in case I forget to put a null character after I use some functions to manipulate strings. It is just a good programming practice not to leave the variables holding garbage.

and

you can also do

Code:

char mystring[MAX] = {};

same thing, and totally valid. Just filling up my array with null characters.

It wont let me! What it is doin is when i click start without debugging it lets me enter the first and second string. Then once I press enter it prints out the first string is larger than the second string infinite times. It wont stop printing that. There is nothin I guess in my program that tells it to stop so thats what I need help at to figure it out.

Originally Posted by jturner38

It wont let me! What it is doin is when i click start without debugging it lets me enter the first and second string. Then once I press enter it prints out the first string is larger than the second string infinite times. It wont stop printing that. There is nothin I guess in my program that tells it to stop so thats what I need help at to figure it out.

did you use the code I posted?... we told you to get rid of the loop and other stuff, use the code I posted, its pretty much the same you had plus some recommendations already given on here.

This is what I have. The program builds successfully from my original to everybody else's way. When u run the program it tells u to enet the first string then enter the second string. The problem is right after u press enter after u have entered the second string it says the first string is larger everytime and not onlyy that but it also prints it out infinte amout of times as in it keeps on running and it never stops. The only way u can stop it is if u exit out of it.

Code:

#include<stdio.h>
#include<string.h>
#include<ctype.h>

#define MAX 100

int main() {

	char s1[MAX] = {0};
	char s2[MAX] = {0};
	int x;
	
	printf("Input first string:\n");
	fgets (s1 , MAX , stdin);

	printf("Input second string:\n");
	fgets (s2 , MAX , stdin);

	x = strcmp(s1, s2);

	if (x == 0)
		printf("These strings are equal\n");
	else if (x > 0)
		printf("The first string is larger\n");
	else
		printf("The second string is larger\n");

	return 0;
}