stack cant find null

[charlitos]

Can somebody help me to find out why does my loop go forever, even when im telling it to stop once it finds NULL?

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>

struct user
{
	int  number;
	char name[15];
	struct user* next;
	
};

struct user* push( struct user* , char * , int fd);

int main()
{ 

	char add2[20]   = "MATT";
	char add4[20]   = "STEVE";
	
	struct user * client;
	struct user * node;
	
	client = NULL;
	
	client = push(client, add2, 5);
	client = push(client, add4, 5);

	for ( node = client; node != NULL; node = client->next)
	{
		printf("%s\n", node->name);
		printf("%d\n", node->number);
	}
	
	return 0;
}

struct user* push( struct user* current_user, char * username , int number) {
  struct user* newtop;
  newtop = (struct user*)malloc(sizeof(*newtop)); 
  
  strncpy(newtop->name, username, strlen(username) + 1);
  newtop->number = number;
  newtop->next = current_user;
  
  return newtop;

}

[quzah]

You're missing headers, without them, NULL isn't actually defined, and it doesn't compile. push is defined after you use it. There is nothing called fd in your structure, so you can't print it. You use size 15 and size 20 for name, in different places. This is just asking for your program to crash. And finally, it should be:

node = node->next

I'd advise you to start using warnings when you compile, and to listen to them and fix them as you encounter them.


Quzah.

[charlitos]

i included all the headers
and the function prototype is also on top

the fd is not like that on my code i just made a mistake after i copied

anyway i edited my code the same way I have it, so all these problems you mentioned are not problems anymore, still it loops forever

[quzah]

That's because when you were editing your code in your first post again, you didn't fix what I specifically pointed out:

for ( node = client; node != NULL; node = client->next)

Quzah.

[charlitos]

oh sorry, i didnt notice that one, thanks a lot