Thread: Help me to Improve

Hello again!
I asked for help before for opening a web page. I got around that and added things to it.
A way to choose your activity, and a way to exit the program.
Well i want feedback on what you think about it. I have an error that happens at the end (when i get the correct password, get the web page opened, and enter "4" to exit the program) that i don't know how to fix. But i also want feedback overall, so go ahead!

here's the code:

Code:

#include <stdio.h>
#include <stdlib.h>
#include <windows.h>

int main()
{
    char* pass="hello";
    char* hint="Form of salutation";
    char* search="http://www.goolge.com";
    char* news="http://www.cnn.com";
    char* email="http://www.hotmail.com";
    int* activity;
    char* p;
    int i=0;
    int a=0;


    printf("Enter password and press ENTER.\n \n");
    do
    {
        printf("Password: ");
        scanf( "%s",  p);

        if(strcmp ( p, pass ) == 0)
        {
            printf("Correct Password. \n \n");
            i=10;
        }
        else
        {
            if(strcmp ( p, "hint" ) == 0)
            {
                printf("Password Hint: %s. \n \n", hint);
            }
            else
            {
                printf("Incorrect Password. \nType 'hint' for help. \n \n");
                i++;
            }
        }

    }
    while (i<3);

    do
    {

        printf("Choose your activity:\n1. Search\n2. News\n3. eMail\n4. Exit\n\n");
        printf("Enter a number: ");
        scanf( "%s",  activity);

        if (strcmp ( activity, "1" ) == 0)
        {
            ShellExecute(NULL, "open", search, NULL, NULL, SW_SHOWNORMAL);
        }

        if (strcmp ( activity, "2" ) == 0)
        {
            ShellExecute(NULL, "open", news, NULL, NULL, SW_SHOWNORMAL);
        }

        if (strcmp ( activity, "3" ) == 0)
        {
            ShellExecute(NULL, "open", email, NULL, NULL, SW_SHOWNORMAL);
        }

        if (strcmp ( activity, "4" ) == 0)
        {
            i=20;
        }

        if (i==10)
        {
            printf("\nOpening application...\n");
            printf("Press any key to continue.\n");
            printf("\n--------------------------------\n\n");
            getch();
        }

    }
    while (i == 10);

    printf("\n---- PROGRAM TERMINATED ----\n--- PRESS ANY KEY TO END ---\n");
    getch();

    return 0;
}

char* search="http://www.goolge.com";

you mispelt the website :-)

thanks Tom

Thanks again Elysia. I think I'd improved... Check it out.. I added a Username also..

Code:

#include <stdio.h>
#include <stdlib.h>
#include <windows.h>

int main()
{
    char user[80]="epijimenez";
    char pass[80]="hello";
    char hint[80]="Form of salutation";
    char search[80]="http://www.goolge.com";
    char news[80]="http://www.cnn.com";
    char email[80]="http://www.hotmail.com";
    int* activity;
    char u[80];
    char p[80];
    int i=0;

do
{
    printf("Username: ");
    scanf( "%s", u);
    if(strcmp ( u, user ) == 0)
        {
            i=5;
        }
        else
        {
            printf("Incorrect Username \n \n");
            i++;
        }
}while (i < 3);


if(i == 5)
{
        do
        {
            printf("Password: ");
            scanf( "%s",  p);

            if(strcmp ( p, pass ) == 0)
            {
                printf("Correct Password. \n \n");
                i=10;
            }
            else
            {
                if(strcmp ( p, "hint" ) == 0)
                {
                    printf("Password Hint: %s. \n \n", hint);
                }
                else
                {
                    printf("Incorrect Password. \nType 'hint' for help. \n \n");
                    i++;
                }
            }

        }while (i<8);
}


    if (i == 10)
    {
        do
        {

            printf("Choose your activity:\n1. Search\n2. News\n3. Email\n4. Exit\n\n");
            printf("Enter a number: ");
            scanf( "%d",  &activity);

            if (activity == 1)
            {
                ShellExecute(NULL, "open", search, NULL, NULL, SW_SHOWNORMAL);
            }

            if (activity == 2)
            {
                ShellExecute(NULL, "open", news, NULL, NULL, SW_SHOWNORMAL);
            }

            if (activity == 3)
            {
                ShellExecute(NULL, "open", email, NULL, NULL, SW_SHOWNORMAL);
            }

            if (activity == 4)
            {
                i=20;
            }

            if (i==10)
            {
                printf("\nOpening application...\n");
                printf("Press any key to continue.\n");
                printf("\n--------------------------------\n\n");
                getch();
            }
        }while (i == 10);
    }

    printf("\n---- PROGRAM TERMINATED ----\n--- PRESS ANY KEY TO END ---\n");
    getch();

    return 0;
}

Thanks again Elysia. Im a beginner in this, so I'm learning every step of the way.
I dont get the scanf problem your talking about. It works fine as of right now :S

And for assigning varibles to each of the elements (password, username, news, search, email) is to be able to change it easily in the future. I just learned about structures, which I might implement it in my project by having a structure for each different username with their own choices of websites (and the password). What do you think about that?

I also learned about the break; command, but not through my professor. I have a kinda of weird professor. Again thanks for your help.