Thread: Problem with memory clean up in calling function

  1. #1
    Registered User
    Join Date
    Mar 2009

    Problem with memory clean up in calling function

    I am working on following code snippet and am having problems stated below. Please help me:

    typedef struct {
    char* hostname;
    int connects;
    } Str;
    char * getandprint(int *argcnt, Str * strarr)
            static char buff[8];
            int i,k;
            Str *strarr1=0;
            strcpy(buff,"PRINTER"); //this will be returned
            printf("count is %d\n",*argcnt);
            for (i=0;i<(*argcnt);i++)
                    strarr1=(Str *)malloc(sizeof(Str));
                    if(strarr1 !=(Str *)0){
                            if(seqarr1 !=(Str *)0) {
                                    printf("outside %d string is %s\n",seqarr[i].connects,seqarr[i].hostname);                        }
            for (i=0;i<(*argcnt);i++)
                    printf("printed %d string is %s\n",seqarr[i].connects,seqarr[i].hostname);        }
            return buff;
    Str * GetStr()
    //This dynamically allocates the memory and then populates Str element and returns pointer to it
    I am able to print everything correctly in the printf of first for loop.(one in Green)

    However, the printf in second for loop(one in red) gives following problems if *argcnt is large:
    1) Some of the initial members print "seqarr[i].connects" correctly but junk values in "seqarr[i].hostname".
    2) The program gives a segmentation fault if the count is very large.

    For example, if count is 3000, for first 45-50 times, seqarr[i].connects is printed correctly but "seqarr[i].hostname" prints junk.
    And after printing some first 2950 times, I get a segmentation fault.

    I suspect these could be due to clean up issues.

    Please let me know why am I getting these errors and how do I correct them?
    Last edited by karthur3; 03-22-2009 at 02:57 PM. Reason: missed out on free()

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. sorting number
    By Leslie in forum C Programming
    Replies: 8
    Last Post: 05-20-2009, 05:23 AM
  2. Compiling sample DarkGDK Program
    By Phyxashun in forum Game Programming
    Replies: 6
    Last Post: 01-27-2009, 03:07 AM
  3. problem getting result when calling a function
    By drb2k2 in forum Windows Programming
    Replies: 1
    Last Post: 04-14-2003, 10:51 AM
  4. Contest Results - May 27, 2002
    By ygfperson in forum A Brief History of
    Replies: 18
    Last Post: 06-18-2002, 02:27 PM
  5. Interface Question
    By smog890 in forum C Programming
    Replies: 11
    Last Post: 06-03-2002, 06:06 PM

Tags for this Thread

Website Security Test