Thread: strcpy() issue

I'm curious if this can work somehow? My goal would be having a dynamic string structure and have functions that operate it more extensively than the standard library. However, I don't want to delete a string after going out of scope every time. Is there any way for strcpy() to copy a value into a String.text? I'm getting an access violation exception right now when it enters strcpy().

Code:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

typedef struct tagString
{
	char *text;
} String;

void String_SetText(String *ob, const char *value)
{
	strcpy(ob->text, value);
}

char *String_GetText(String *ob)
{
	return ob->text; 
}

int main(void)
{ 
	String str; 

	String_SetText(&str, "Hello World!");

	printf("%s\n", String_GetText(&str));

	system("pause");
	return 0;
}

You have to have memory before you can write to it. Your text member would point to memory, if you had any, but you don't. You need to first acquire memory, using malloc and friends, and then work with that memory.

Originally Posted by philvaira

I was afraid of that. Unfortunately that means having something like String_Release(&str); at the end of every function that initializes a new string. Is there any way around it?

I don't see why it would mean anything of the sort. You wouldn't want to release the string until you're done with it.

(Unless you mean that you are done with it, in which case you would want to indicate that by calling a function like String_Release.)