Thread: problem with comparing tokenised strings with array elements

your filds have spaces inside - use Trim (samples of such function were posted not long ago) to get rid of them

also - read FAQ about using feof to control loops (you should not)

Code:

while ( fgets(rida, sizeof(rida), fp))

should be used

Code:

    n=sizeof(old_EU)/sizeof(int); // get the number of different countries in array

Warning, Warning - sizeof(int) != sizoef(char*) in all circumstances, so your n may be half of what you expect [for example].

--
Mats

(sorry if I duplicate anything mentioned above)

Code:

#include <stdio.h> // standard IO
#include <conio.h> // keyboard-monitor  note that conio.h is deprecated in C99 IIRC
#include <stdlib.h>
#include <string.h>
#include <ctype.h>

int main(void) 
{ 
    int n, i; // variables declaring
    int x = 0;
    char *old_EU[] = {"Austria", "Belgium", "Spain", "Holland", "Ireland", "Italy", "Greece", "Luxembrug", "Portugal", 
    "France", "Sweden", "Germany", "Finnish", "Great Britain", "Denmark"};
    n=sizeof(old_EU)/sizeof(int); // get the number of different countries in array Bad idea. As matsp points out, this won't give the result you're looking for.
    char *file="c:\\Import.xml"; // you can use forward slashes when using the C standard library
    char rida[240], *pos;// why 240? where does this magic number come from?
    FILE *fp;
   	fp=fopen(file, "r"); // these two lines can be changed to if((fp = fopen(file, "r")) != NULL)
	if(fp){ // file opened successfully
	   while (!feof(fp)){ // as mentioned before, using feof to control a loop is a pretty bad idea. replace this and the next line with while(fgets(rida, sizeof(rida), fp) != EOF)
	       fgets(rida, sizeof(rida), fp); // duplicated below! there's a way to avoid this . . . there's a reason that you have a do . . . while loop down there . . . even if you are using this to get past the first '<' in the xml file, it's still a bad idea to duplicate code like this. think on it, there *is* a better way.
	       pos=strtok(rida, "<>");
	       do{
              for (i=0; i<n; i++) {
              if (strcmp(old_EU[i], pos) == 0)                      
              x++;
              //printf("%d", x);
              }
              printf("%s\n", pos);
              pos=strtok(NULL, "<>");
           }while(pos && *pos!='\n');
	   }
    }  
    else printf
	("File %s couldnt be opened\n",
		file);
	printf("\n%d , % d", x, n); // why x?
    printf("\nPress any key...");
    getch();  [color=red]// use getchar(), not getch() . . .
    return 0;
}

Hope this helps a little.

thanks alot for your help, i can't edit my first post and thread-title so i need make a new post now.
thanks for the help, didn't notice that the problem is in the space. it finds the array elements from the file now. what i wanted to do is to sum all these countries import numbers which are found from my array. got some pseudocode in my mind... so how to to jump 2 lines ahead where the number is(for which functions/commands should i search the web?)? and then i assume to convert it with atoi to integer

didnt know that C doesnt have trim function, i searched for some on the web, but they seem to be complicated and not explained, ill leave it for next step.

Code:

int main(void) 
{ 
    int n, i; // variables declaring
    int x = 0;
    char *old_EU[] = {"Austria ", "Belgium ", "Spain ", "Holland ", "Ireland ", "Italy ", "Greece ", "Luxembrug ", "Portugal ", 
    "France ", "Sweden ", "Germany ", "Finnish ", "Great Britain ", "Denmark "};
    n=sizeof(old_EU)/sizeof(int); /* get the number of different countries in array
 Bad idea. This won't give the result you're looking for. 
but it works now for me with these small arrays, i havent seen other ways to count em */
    char *file="c://Import.xml";
    char rida[240], *pos;
    FILE *fp;
   	fp=fopen(file, "r"); /* these two lines can be changed to if((fp = fopen(file, "r")) != NULL) 
it brings me message then that expected unqualified-id before "else" and ; expected */
	if(fp){ // file opened successfully
	   while (fgets(rida, sizeof(rida), fp) != NULL) { // explanation why -  http://faq.cprogramming.com/cgi-bin/smartfaq.cgi?answer=1046476070&id=1043284351
           pos=strtok(rida, "<>");
	       do{
              for (i=0; i<n; i++) {
              if (strcmp(old_EU[i], pos) == 0)                      
              x++;
              //printf("%d", x);
              }
              printf("%s\n", pos);
              pos=strtok(NULL, "<>");
           }while(pos && *pos!='\n');
	   }
    }  
    else {
         printf("File %s couldnt be opened\n", file);
         }
	printf("\n%d, % d", x, n); /* why x? 
just to see how many elements it found */
    printf("\nPress any key...");
    getch();  /* use getchar(), not getch() . . . 
well, with getchar it closes only when i press "enter" but with getch it closes with any key pressed as written on the screen printf("\nPress any key..."); */

    return 0;
}