problem in a function

[lolguy]

i m trying to code a function whish uses strstr and has unlimited parameter but i alawys get return 0 i dunno why

#include <stdio.h>
#include <windows.h>
#include <string.h>
int my_strstr(char *searching,char *buffer,char *stuff,...)//searching is our stuff we will search inside buffer whish we will sprintf stuff into and stuff for unlimited param
{
    va_list varagums;
	va_start( varagums, stuff );
	vsprintf( buffer, stuff, varagums );
	va_end(varagums);
	if(strstr(searching,stuff))
		return 1;
	else
		return 0;

}
int main(void)
{
	char first[]="LOLGUY";
	char buffer[100];
	char sur[]="good looolz LOLGUY";
	if(my_strstr(sur,buffer,"%s",first))
		puts("found it");
	else
	{
		puts("didnt find it");
		puts(buffer);
	}
	return 0;
}

[cas]

if(strstr(searching,stuff))

Presumably you meant buffer instead of stuff here, being that stuff is your format string. I'd recommend more descriptive variable names, as that would probably have helped you see the problem quickly.

[lolguy]

no buffer is the stuff i write to like normal strstr(searching,"lolguy") that will search lolguy i want mine to have unlimited parameters to edit the bufffer l8er on.

[vart]

no buffer is the stuff i write to like normal strstr(searching,"lolguy") that will search lolguy i want mine to have unlimited parameters to edit the bufffer l8er on.

stuff contains "%s" string - there is no chance to find it in the searchstring... you need to rethink what you want to do

[matsp]

For this sort of thing, varargs doesn't seem like the right solution [generally speaking].

I have solved this sort of problem (find something in a list of things) by passing in an array into a function, e.g.

const char *haystacks[] = { "one", "two", "three", "four", ..., "twentythree" .. };

multi_strstr(const char *needle, const char *haystacks, int size)
{
    int i;
    for(i = 0; i < size; i++)
    {
        if (strstr(needle, haystacks[i]))
           return i+1;
    }
    return 0;
}

int main()
{
    printf("Searching for three in haystacks gives %d\n", multi_strstr("three", haystacks));
    return 0;
}

Much easier to understand, and probably more efficient as well.

--
Mats

[lolguy]

yah but i m trying to make an irc bot whish when u find in buffer !say it will copy the stuff by strcpy into a new buffer to send it back to orginal channel

[lolguy]

vart since i passed also %s into varags it has unlimite parameter so it will put it in buffer so when it found !say i ill put it into buffer to modify it after that in my to send the stuff back after !say

[slingerland3g]

You can run into some very dire memory allocation issues using your varargs method. Use strtok from what you have used strcpy on from your data and throw that into an array as matsp has mentioned would be preffered.

[lolguy]

i ill try i hope it works

[vart]

vart since i passed also %s into varags it has unlimite parameter so it will put it in buffer so when it found !say i ill put it into buffer to modify it after that in my to send the stuff back after !say

That's why it was said - you need to search for contents of the buffer, not stuff