Warning: Initialization makes integer from pointer without a cast

**nexusdarkblue** · 03-08-2009

Hello everyone,

I am somewhat new to C programming (I started last year) and I'm fairly good at it so far...that is, until I've recently started working with structures.

In my current program, I'm simply trying to initialize a simple array of structures that will be the test template for other similar programs I plan on using in the future. The program is as follows:

Code:

#include <stdio.h> int main(int argc, char *argv[]) { int time, closest; struct flight { int depart[FLIGHTS]; int arrive[FLIGHTS]; char *attendant; }; struct flight schedule[] = {{800, 1016, "Jason Mackenzie"}, {943, 1152, "Valerie Woods"}, {1119, 1331, "Antonio Vasquez"}, {1247, 1500, "Natalie McIver"}, {1400, 1608, "Scott Curtis"}, {1545, 1755, "Yvonne Vogelar"}, {1900, 2120, "Mitch Matthews"}, {2145, 2358, "Marcie Maddox"}}; printf("%d\n", schedule[0].arrive[0]); return 0; }

For each line where I'm trying to initialize each index of the schedule array, the
compiler gives me the warning "initialization makes integer from pointer without a cast" and I can't figure out why.

To test to see if my code was correct or not, I used a simple printf( ) statement, and all I got for the output was zero, so I'm obviously doing something wrong here. Can anyone help? I'd really appreciate it--thanks!

RICH

**Elysia** · 03-08-2009

depart & arrive are arrays, but you are only trying to assign one value to them.
The compiler assumes that the first {} is for initializing the depart arrays, and thus you are truncating the strings (const char*) to int.
Also remember that string literals should be const char* because they are read-only in most cases.

**nexusdarkblue** · 03-09-2009

Thanks for the help, Elysia. But then I realized that I didn't mean for 'depart' and 'arrive' to be arrays--they're just integer values that are part of my array of structures. I did change my string literal to be const char*, so thanks for that advice!

**nonoob** · 03-09-2009

One thing you might consider is to define a template.

For example:

Code:

typedef struct {
	int depart;
	int arrive;
        const char *attendant;
	} FLIGHT_DEF;

Then declare the actual storage and contents:

Code:

FLIGHT_DEF flight[] = {
	{800, 1016, "Jason Mackenzie"},
	{943, 1152, "Valerie Woods"},
 	{1119, 1331, "Antonio Vasquez"},
	{1247, 1500, "Natalie McIver"},                   
	{1400, 1608, "Scott Curtis"},
	{1545, 1755, "Yvonne Vogelar"},
	{1900, 2120, "Mitch Matthews"},
	{2145, 2358, "Marcie Maddox"},
	};

The advantage there is that you may now use FLIGHT_DEF as a parameter type to functions (cast), or determine number of elements:

Code:

#define FLIGHT_DEF_SIZE		(sizeof(flight)/sizeof(FLIGHT_DEF))

... which could come in handy.

The capitalization and closing brace on separate line are old habits. Makes adding/deleting records easier. Eventually I take all the capitalized typedefs into a separate include file so that they may become available in other modules.

**Elysia** · 03-10-2009

Originally Posted by nonoob

The capitalization and closing brace on separate line are old habits.

And not necessarily bad ones, either. It makes code more readable in my opinion.

Thread: Warning: Initialization makes integer from pointer without a cast

Thread Tools

Search Thread

Display

Warning: Initialization makes integer from pointer without a cast

Similar Threads

Looking for constructive criticism

Dev-cpp - compiler options

assignment makes pointer from integer

Interface Question

Warning: assignment makes integer from pointer without a cast