Thread: Counting groups of lines

I'm sorry for the confusion. My program may be a little messy, I sometimes use english variable names and sometimes dutch, no particular reason, it just happens. I'll post them in english from now on to avoid confusion .

This is pretty much the whole program:

Code:

#include <stdlib.h>
#include <stdio.h>
#include <math.h>

long no_lines=0;
char *dummyline;

char *Combinations_systemname[84] = {"Black Hole - Carbon Star","Black Hole - Helium Star","Black Hole - Black Hole", and a whole lot more combinations.......};


//********************
//Functions:
//********************

int Linecount(char* filename_array[],int n){

     char filename[100]; 
     no_lines=0;
     sprintf(filename, "%s.txt", filename_array[n]);



     FILE* file = fopen(filename,"r");
     
     
     if (file!=NULL){
     

         char dummyline[1000];
      
         while ( fgets(dummyline, 1000, file) != NULL) no_lines++;  
         
         printf("Scanned: %s\n",filename); //testing filename
         printf("%s",dummyline);  //just for testing if last line in the file is indeed from the correct file

         fclose(file); 

         return no_lines;
     
         
     
     } else {printf("!! %s File not available\n",filename);
             return no_lines=0;
            }

      

}

//********************
//Main Program
//********************


int main (){

int no_of_systems=0;

   
FILE* No_binarysystems_file = fopen("Aantal_dubbelsterren.txt","w");

  

int i=0;



    for (i=0;i<84;i++){
               
                 Linecount(Combinations_systemname,i);
                 

                 
                 no_of_systems = no_lines/3;
                 
                 printf("no_lines=%d \n",no_lines);
                 
                 printf("Number of systems of this type: %d\n\n",no_of_systems);
                 
                 fprintf(No_binarysystems_file,"%s,%d\n",Combinations_systemname[i],no_of_systems);  
}


         

fclose(No_binarysystems_file);

//================================================//   

  //to make sure window doesn't close right away.
   #ifdef _WIN32
     system("PAUSE");
   #endif
   



    
   return (0);
}

Meanwhile I've found a corrupt textfile and that one happend to be the one I tested if the number of systems was correct. Not much of a test! Anyway. It does seem to work afterall.

no_lines has no reason to be a global, so you should fix that up.

No reason for a global variable char * dummyline.

Code:

char *Combinations_systemname[84] = {"Black Hole - Carbon Star","Black Hole - Helium Star","Black Hole - Black Hole", and a whole lot more combinations.......};

Why not use a line per each, like this:

Code:

char *Combinations_systemname[] = 
{
     "Black Hole - Carbon Star",
     "Black Hole - Helium Star",
     "Black Hole - Black Hole", 
     and a whole lot more combinations.......
};

To make it simple to change, I also removed the 84 in the brackets. Of course, you will have to change the for-loop:

Code:

    for (i=0;i<sizeof(Combinations_systemname)/sizeof(Combinations_systemname[0]);i++)

Originally Posted by Ayreon

But now in order to make it work I need to declare no_lines twice. In the function itself and in the main.

Yes, but it's much "better" that way - the reason is that you have control over where each of those no_lines variables are being used. Global variables tend to get messy after a while, and there's no good way (once the program gets a bit larger) to track where the variables are updated and where it is safe to change it. It is also quite likely that the compiler will generate better code for local variables.

--
Mats

Originally Posted by Ayreon

I also don't understand this part of the for loop:
sizeof(Combinations_systemname)/sizeof(Combinations_systemname[0])

Why can't I just use "sizeof(Combinations_systemname)". What is the other part for?

The first sizeof gives the number of bytes occupied by the char * in the array - since that is 4 or 8 times larger than what you want, we divide by the first element (which is a single char *), and get the number of elements in the array - it s a "standard way" of counting the number of things in an array. Just remember that this ONLY works if you have the original array - it doesn't work for arrays passed into a function.

Oh, and change char * to const char * in the declaration of Combinations_systemname - that prevents someone from accidentally changing the code to write to the array and causing a crash (because the elements can not be written to).
--
Mats

Originally Posted by Ayreon

Ok, that's clear. Thanks for the extra "tidying up".
If you got any more tips, they're welcome.

Oh, and one more thing, what exactly do you mean by "passed into a function". Isn't that what happens with my array, I am using it in my function. "Passed into function" probably isn't the same as "used by function" then?

By passed to a function, I mean just that - an argument to a function. Not "used in a function". Since it is a global variable (and this sort of global is OK - it is not modified, for one thing).

--
Mats

Earlier on in this topic Matsp said:

Originally Posted by matsp

And to be sure, you may want to add:

Code:

int len;   // at the beginning of the while-loop. 
...
// after fgets() != NULL
   len = strlen(dummyline);
   if (len && dummyline(len-1) != '\n')
      printf("dummyline is not big enough at %d lines\n", no_lines);

I'm trying to combine several programs into one, and I want to improve the reliability. So I think it's a good idea to use this in case a line is too long (I did find such lines in two corrupt files).

Am I doing it right this way?:

Code:

int len;

while ( fgets(dummyline, 1000, file) != NULL) {
              len = strlen(dummyline);
              if (len && dummyline(len-1) != '\n'){
                       printf("dummyline is not big enough at %d lines\n", no_lines);
              }else{
                       no_lines++;
                       }
}

Or maybe in stead of printf I could save a variable with this information, because de printf screen can only hold so many lines and this messege could fall off, and you would never notice it happened, right?