Printable View
If we had something "easy" and we needed to deal with ties, normally we'd just do a second pass through the input (one pass to find what the largest one is, the second to print every input that matched). In this case, since you probably don't want to do that, either (a) you resign yourself to only getting the last/first or (b) you set up a dynamic array of the i's which correspond to the largest file.
You will not under any circumstances want to store a bunch of file pointers. Open a file, process it, close it, move on to the next. You shouldn't have more than one file open at a time.Quote:
Originally Posted by Lucid15
sorry small typo... go off of this code.Code://Compares upto 100 files, and decides which one has the most characters(bytes) and which has the most words.
#include <stdio.h>
#include <stdlib.h>
int i;
int main(int argc,char **argv)
{
int c,w,n,max_char[n],max_words[n],numtotal,numwords,numchars;
char most_words,most_chars;
FILE *f[n],*g;
n=0;
numchars=0;
numtotal=0;
for (i=1;i <= argc;i++){
f[n]=fopen(argv[i],"r");
if(f[n]==NULL){
printf("Can't open %s \n",argv[i]);
exit(0);
break;
}
else{
fgetc(f[n]);
while(c != EOF){
if(c==' '){
numwords++;
}
c=getc(f[n]);
numchars++;
}
}
n++;
exit(1);
}
printf("%d",numchars);
}
So all the CAN'T DO THIS still apply in this code just as much as the other.Quote:
Originally Posted by Lucid15
it still will not print the number of characters in a file.... it just doesnt output anything..Code://Compares upto 100 files, and decides which one has the most characters(bytes) and which has the most words.
#include <stdio.h>
#include <stdlib.h>
int i;
int main(int argc,char **argv)
{
int n;
n=0;
int c,w,max_char[n],max_words[n],numtotal,numwords,numchars;
char most_words,most_chars;
FILE *g;
numtotal=0;
for (i=1;i <= argc;i++){
g=fopen(argv[i],"r");
if(g==NULL){
printf("Can't open %s \n",argv[i]);
exit(0);
break;
}
else{
fgetc(g);
while(c != EOF){
c=getc(g);
if(c==' '){
numwords++;
}
numchars++;
}
}
n++;
exit(1);
}
printf("%d",numchars);
}
And what do you think "exit(1)" does?
Just a couple of thoughts. You probably want to start from scratch and think this through from a fresh start. For instance - what is n doing?
You need to fclose() each file once you're done working with it.
Your calls to fgetc and getc need to be sorted out. You need to call fgetc for every character until you reach the end of the file.
If you exit(0) in the middle of your loop, you won't process all the files AFTER that point, and it looks like you want it to keep going.
There's probably others, but it's a little hard to follow your logic because there are several errors that make the code unclear.
Again, I would recommend starting from scratch, and mapping out the simple steps you need to do.
getting a "can't open (null)" code in the terminal
argv[argc] is NULL.Quote:
Originally Posted by Lucid15
if argc is 1, then you haven't invoked your executable with a command line argument. And NULL isn't something you can open like a file (but that's not really the problem).
i have this code now to just check to see if it can get one file right.Typing this into terminal and getting that outputCode://Compares upto 100 files, and decides which one has the most characters(bytes) and which has the most words.
#include <stdio.h>
#include <stdlib.h>
int i;
int main(int argc,char **argv)
{
int numwords,numchars,c;
FILE *f;
numchars=0;
numwords=0;
for (i=1;i <= argc;i++){
f=fopen(argv[i],"r");
if(f==NULL){
printf("Can't open %s \n",argv[i]);
exit(0);
}
fgetc(f);
numchars++;
while (c != EOF){
c=fgetc(f);
if(c==' '){
numwords++;
}
numchars++;
}
printf("%d %d\n",numchars,numwords);
}
}
that file contains this:Code:./a.out split_grade_file.input
262 99
Can't open (null)
Code:Berwick Paul pokerface 72
Chen Ankim Undefeated 90
Cromwell Janet TH867jkl 88
Jones Sara tornado 94
Smith Harrison HotDog 85
Townsend Douglas hyperbolic 89
Powell Joseph abcdefg 72
argv[argc] is still NULL.
You know that a loop condition like i <= argc will access it, right?
lol, sorry. i fixed that didnt update it before i posted.
ok i think im getting somewhere now. but still getting an error.ERROR:Code://Compares upto 100 files, and decides which one has the most characters(bytes) and which has the most words.
#include <stdio.h>
#include <stdlib.h>
int i;
int main(int argc,char **argv)
{
int numwords,numchars,c,maxchars,maxwords,p,q;
char name[p],name2[q];
FILE *f;
numchars=0;
numwords=0;
maxchars=0;
maxwords=0;
p=0;
q=0;
for (i=1;i < argc;i++){
f=fopen(argv[i],"r");
if(f==NULL){
printf("Can't open %s \n",argv[i]);
exit(0);
}
fgetc(f);
numchars++;
while (c != EOF){
c=fgetc(f);
if(c==' '){
numwords++;
}
numchars++;
}
if(numchars >= maxchars){
maxchars=numchars;
name[p]=argv[i];
p++;
}
if(numwords >= maxwords){
maxwords=numwords;
name2[q]=argv[i];
q++;
}
}
}
Code:2-9.c: In function ‘main’:
2-9.c:33: warning: assignment makes integer from pointer without a cast
2-9.c:38: warning: assignment makes integer from pointer without a cast
edit: posted while I was typing...
The error involves the assignments to name[p] and name[q]. Coincidentally, name is not necessary (especially considering the way you want to use it), just assign p = i and q = i when numchars >= maxchars and numwords >= maxwords, respectively. If done right, then argv[p] is the name of the file with the most characters, and argv[q] is the name of the file with the most words.
But i need it to display all of which are equal to the max values... so that if some are the same values at max it prints both of them.. will this do that?