Thread: Noob help

Originally Posted by vart

What is your question?

The program only prints parts of a string and not all the string longer than MIN

getline returns the number of characters read, but it also stores the '\n' at len-1. If you try to read MIN characters and there's no '\n', that means the line was too long and you can loop to get the rest of it. mucho easier than what you were doing before.

Code:

int main()
{
    char line[MAXLINE];
    int len;
    while((len = getline(line, MIN)) > 0)
    {
        if (line[len-1] != '\n')
        {
            while (line[len-1] != '\n')
            {
                printf("%s", line);
                len = getline(line, MIN);
            }
            printf("%s", line);
        }
    }
    return 0;
}

getline is wrong too. you don't ever store the '\0' at the end. you have to make room for it and store it or printing the strings won't work right.

Code:

int getline(char s[], int lim)
{
    int c, i;
    for (i = 0; i < lim-1 && (c = getchar()) != EOF && c != '\n'; i++)
        s[i] = c;
    if (c == '\n') s[i++] = c;
    s[i] = '\0';
    return i;
}

Originally Posted by matsp

Code:

MAXLENGHT

Please try to use correct, English, spelling (so TH, not HT at the end). [No, it doesn't make your code work better - but at some point sooner or later, you will wonder why the **** MAXLENGTH is "undefined" according to the compiler].
Mats

You are right, sorry...

Originally Posted by vart

I see the opposite effect - your programs prints too much - becuase your lines_saved buffer is not nul-terminated

Thanks! This one do the trick.

Now it works

Code:

#include <stdio.h>

#define MIN 80             /* print lines longer than this one */
#define MAXLENGTH  10000     /* the main arrays where all the lines will we saved */
#define MAXLINE  1000      /* mac line length */

int getline(char s[], int lim);
void copy_to_lines(char from[], char to[], int position, int len);

int main()
{
    char line[MAXLINE];
    char lines_saved[MAXLENGHT];
    int current_position = 0;
    int len = 0;
    int i;

    while((len = getline(line, MAXLINE)) > 0)
    {
        if (len > MIN) {
            copy_to_lines(line, lines_saved, current_position, len);
            current_position += len;
        } 
    }
    printf("%s", lines_saved);

    return 0;
}

int getline(char s[], int lim)
{
    int c, i;

    for (i = 0; i < lim && (c = getchar()) != EOF && c != '\n'; ++i)
    {
        s[i] = c;
    }
    if (c == '\n') {
        s[i] = c;
        ++i;
    } 
    s[i] = '\0';

    return i;
}

void copy_to_lines(char from[], char to[], int position, int len)
{
    int i = 0;

    while((to[position] = from[i]) != '\0')
    {
        ++i;
        ++position;
    }
}

i will ad more question in this post, when i have problems or doubts.
Both, many thanks!