Thread: noob problem in code

hey i wanted to do this character validator i tried running into for loop then
chking if each character are == but i dunno whats wrong

Code:

#include <stdio.h>
int main(void)
{
	char stuff[]="ASDFGHJKL;'/.,mnbvcxzqwertyuiop[]=-09038837351523535355,znbzvvvgjkkld";
	char validator[]="asdfghjklmnbvcxzqwertyuiop";
	int i;
	int x;
	for(i=0,x=0;stuff[i]!='\0',validator[x]!='\0';i++,x++)
	{
		if(stuff[i]==validator[x])
			printf("%c",stuff[i]);
			
	}
	return 0;
}

Can we assume that "asdfghjklmnbvcxzqwertyuiop" are are to be considered 'valid' characters? If so, try a nested loop - I think that is what you are after. Basically you want to test the first character in stuff ('A') agains every character in validator. Then you want to increment stuff[i], and check the next character ('S') against every character in validator, and so on. The outer loop would increment the array index for stuff, and the inner loop would run through each character in validator.

but i alrdy did it in for loop shoudlnt this increment it ? and how can i increment a character in a for loop?

You increment the index to the array, which "moves" down to the next letter/character.

how can i increment it inside the loop ? so i can chk each character == to other in the increment?

oh thanks i ill try

I did this

Code:

#include <stdio.h>
int main(void)
{
	char stuff[]="ASDFGHJKL;'/.,mnbvcxzqwertyuiop[]=-09038837351523535355,znbzvvvgjkkld";
	char validator[]="asdfghjklmnbvcxzqwertyuiop";
	int i;
	int x;
	for(i=0;i<=sizeof stuff;i++)
	{
		for(x=0;x<sizeof validator;x++)
		{
			if(stuff[i]==validator[x])
			{
				stuff[++i]=validator[++x];
				printf("%c",stuff[i]);
			}
		}
	}
	return 0;
}

didnt rlly work out accurate i think
dunno where is the problem

Take out the 'stuff[++i]=validator[++x];'

With that taken out, I get "mnbvcxzqwertyuiopznbzvvvgjkkld" as the output.

Not 100% sure if that's what you wanted, but I think so.

Btw, if you compare an uppercase character to a lowercase character it will return 0, because they are not equal. So if you were expecting the first 9 characters to be in there they won't be.

Take out the ++i and ++x. I and x are incremented, through their respective for loops.

yah thanks alot it works now

Code:

#include <stdio.h>
int main(void)
{
	char stuff[]="ASDFGHJKL;'/.,mnbvcxzqwertyuiop[]=-09038837351523535355,znbzvvvgjkkld";
	char validator[]="asdfghjklmnbvcxzqwertyuiop";
	int i;
	int x;
	for(i=0;i<=sizeof stuff;i++)
	{
		for(x=0;x<sizeof validator;x++)
		{
			if(stuff[i]==validator[x])
			{
				printf("%c",stuff[i]);
			}
		}
	}
	return 0;
}

thanks alot guys and lolguy i understand it now