What is wrong with the year 2000?

[Silverdream]

I have written a program that accepts the year gives the day on which displays the day on which the 1st of january falls. The program works for years upto 1999, but not after that. I think it may be a silly mistake. Please help

#include <stdio.h>

int main()
{
       int temp, given_year, counter=1;


       printf("Enter the year\n");
       scanf("%4d",&given_year);

       for(temp=1900;temp<=given_year;temp++)
       {
	if((temp-1)%4==0)
	{
                    if(counter<7)
	    {
	         counter=counter+2;
	    }
	    else
	    {
	         counter=2;
	    }
	}
	else
	{
                     if(counter<7)
	     {
	         counter++;
	     }
	     else
	     {
	         counter=1;
	     }
	}
           }

     switch(counter)
      {
	case 1:
		printf("Monday");
		break;
	case 2:
		printf("Tuesday");
		break;
	case 3:
		printf("Wednesday");
		break;
	case 4:
		printf("Thursday");
		break;
	case 5:
		printf("Friday");
		break;
	case 6:
		printf("Saturday");
		break;
	case 7:
		printf("Sunday");
		break;
	default:
		exit();
        }

      return 0;
}

[nvoigt]

I don't know what your code does or is supposed to do. Please be a bit more elaborate with the "doesn't work" part next time.

>if((temp-1)%4==0)


If this is a check if the year has a Feb. 29, take in account that this is not the full formula. A year has a Feb. 29, if

a) it's divisable by four
b) not divisable by 100, exception: divisable by 400.

[Silverdream]

Sorry that i wasnt clear!.

Well here it goes again.

i have written a program which accepts a year from the user. It then displays the day on which the first of January fell in that year.

For example

if the user enters the year 1980.

the program displays tuesday

Because January 1st 1980 was a tuesday.

Now what i want to know is that the program displays the day for all the years upto 1999 but after that for the year 2000 it displays nothing and for the years after 2000 it displays the wrong day. I hope i have made the program clear now.

[Stoned_Coder]

I have posted a full calender app on these boards several times.That calender app uses Zeller's algorithm. Look at the code or search for zeller's algorithm at google. zellers algorithm tells you the day for a given date and is valid for all of the gregorian calender.

[Brian]

Just had a few problems. I also made the days an array of strings because it looks cooler and is probably better.

#include <stdio.h>

int main(void)
{
 int temp, given_year, counter=1;
 char theday[7][10] = { "Monday", "Tuesday", "Wednesday", 
                        "Thursday", "Friday", "Saturday", 
                        "Sunday" };
 
 printf("Enter the year\n");
 scanf("%4d",&given_year);   
 if(given_year < 1900)
 {
  printf("Year has to be 1900 or above.");
  return -1;
 }
 for(temp=1900;temp<=given_year;temp++)
 {
  if((temp-1)%4 == 0 && ((temp-1)%100 == 0 || (temp-1)%400 != 0))
  {
   if(counter<7)
    counter+=2;
   else
    counter=2;  
  }
  else
  {
   if(counter<=7)
    counter++;
   else
    counter=1;
  }
 }
 printf("%s",theday[counter-2]);
 return 0;
}

[Brian]

Guess I was kinda giving you a fysh there, but oh well.

[QuestionC]

You really need to zero-index your days. go 0-6, not 1-7. This is why...

if((temp-1)%4==0)
	{
                    if(counter<7)
	    {
	         counter=counter+2;
	    }
	    else
	    {
	         counter=2;
	    }
	}
	else
	{
                     if(counter<7)
	     {
	         counter++;
	     }
	     else
	     {
	         counter=1;
	     }
	}

You'd do much better to replace this code with

if((temp-1)%4==0)
	{
                  counter = (counter + 2) % 7;
	}
	else
	{
                   counter = (counter + 1) % 7;
	}

Your code will always switch to Tuesday when it rolls over on a leap year, whether or not it was supposed to go to Monday or Tuesday. Also, in your program it is possible for your program to end with counter > 7, cinsider the following code

if(counter<7)
	    {
	         counter=counter+2;
	    }
	    else
	    {
	         counter=2;
	    }

With counter intiaially valued at 6.