Thread: Weird error

today i made FILE I/O but i wanted the user to press his like if he want name lol.txt it will make it as lol.txt i made it work but it only accept 10 char array when i change the fgets to lets say 100 it doesnt want to :S i dunno whats with this error

Code:

#include "inc.h"
int main(void)
{
    char name[100];
    FILE*fptr;
    printf("Where do u wanna save your file  ??");
    fputs("PLease enter your file name: ",stdout);
    fgets(name,10,stdin);
    fptr=fopen(name,"w");
    if(fptr==NULL)
{
                  fprintf(stderr,"Coudlnt Access %s - because %s",name,sys_errlist[errno]);
                  exit(1);
}
fprintf(fptr," ");
getchar();
fclose(fptr);
    return 0;
}

coz invalid arguments ??why is that and why have i got error opening ??

thanks i fixed it now

Code:

#include <stdio.h>
#include <stdlib.h>
int main(void)
{
    char name[100];
    FILE*fptr;
    int i;
    printf("Where do u wanna save your file  ??");
    fputs("PLease enter your file name: ",stdout);
    fgets(name,100,stdin);
    for(i=0;i<100;i++)
    {
                      if(name[i]=='\n')
                      {
                                       name[i]=NULL;
                                       }
}
    fptr=fopen(name,"w");
    if(fptr==NULL)
{
                  fprintf(stderr,"Coudlnt Access %s - because %s",name,sys_errlist[errno]);
                  getchar();
                  exit(1);
}
fprintf(fptr," ");
getchar();
fclose(fptr);
    return 0;
}

it compiles fine with msv6 but with dev i get this error
assignment makes integer from pointer without a cast

i dunno why

Originally Posted by brewbuck

Because NULL is a pointer type, and you are assigning it to a character. Instead of NULL use '\0' or just 0.

thanks

Originally Posted by matsp

And writing code that loops through the entire string when there are nice functons like "strchr" that finds a character in the string as a standard function seems like asking for trouble.

Also, you should probably use MAX_PATH instead of 100 - as that is the value of the max length of a (non-redundant) path+filename. Of course, if you throw in a load of . and .. in the filename, you can make it infinitely long, since you can append as many "/foo/../foo/.." as you like and still be in the same place.

--
Mats

yah i was gonna change defines i ill do in end coz this is base of my program but thanks for the tip for strchr it sounds like cool function i ill look into it now

i m trying to do the other part of the code but i get compiler error i think coz i m lil bad with multi dimensional arrays

Code:

#include <stdio.h>
#include <stdlib.h>
int main(void)
{
    char name[10][100];//we got 10 strings and each of them are length 100
    FILE*fptr;
    int i;
    char yesno;
	int x;
	for(i=0;i<10;i++)
	{
                     printf("enter your Name of the file num %d",i+1);
                     scanf("%s",&name[i]);
                     fptr=fopen(name[i],"w");
    if(fptr==NULL)
{
                  fprintf(stderr,"Coudlnt Access %s - because %s",name,sys_errlist[errno]);
                  getchar();
                  exit(1);
}
                     printf("Do you wanna continue ??");
                     scanf("%c",&yesno);
                     if(yesno=='N' || yesno=='n')
                     {
                                   break;
                              }
	}
    for(x=0;x<100;x++)
    {
                      if(name[x]=='\n')
                      {
                                       name[x]=0;
                                       }
}
fprintf(fptr," ");
getchar();
fclose(fptr);
    return 0;
}