strings + file help!

[iunah]

my goal is to retrieve names from a file, save it to an array and save its changes as to program terminates. also, the user cannot add a name that already exists, despite of its case. can someone please tell me what's wrong with my code? it can't compare efficiently those names from the file to the ones which the user entered.. i tried everything i could do... thanks for all the help

here is a fragment of my code:

typedef struct{
    char name[maxChar];
}namelist;

int ind = 1;

void addName(namelist names[], char aname[], int pos){
     int i, comp = 0, ind2 = ind;
     char temp[maxChar], temp2[maxChar];
     
        strcpy(temp,addname);
        for(i = 1; i < ind; i++){
           strcpy(temp2,names[i].name);
		   if((strcmpi(temp, temp2))==0){
			comp++;
		   }
        }
     
        if(comp == 0){
           if(ind < pos || pos < 1) printf("\nWarning: Cannot add at position %d!\n",pos);
           else if(ind > pos && ind != 1){
				while(ind2 >= pos){
                names[ind2 + 1] = names[ind2];
                ind2--;
            }
            strcpy(names[pos].name, aname);
            ind++;
		   }
           else strcpy(names[ind++].name,aname);
       }
	   else printf("\nWarning: %s is already in the list!\n",aname);

}
 
int main(){
    int ch, pos, i;
    namelist names[100];
    char name[30], c[30];
    FILE *file;
    
    file = fopen("CRUSHLIST.txt", "r+");
    
    printf("\nRetrieving CRUSHLIST.txt...\n");
    
    if(file==NULL) {
    printf("\nError: can't open file.\n");
    exit(1);
    }
    else {
    printf("\nFile opened successfully! Retrieving contents...\n");
        for(i = 1; fgets(c, sizeof(c), file)!=NULL ; i++){
           if(c[strlen(c)-1] == '\n') c[strlen(c)-1] = 0;
           strcpy(names[i].name,c);
              ind++; //else which is previously there was a typo.. my apologies
       }
    }
    
    do{
       ch = menu();
        switch(ch){
                   case 1: printf("Enter name: ");
                           fgets(name,sizeof(name),stdin);
                           if(name[strlen(name)-1] == '\n') name[strlen(name)-1] = 0;
                           printf("Enter position: ");
                           scanf("%d",&pos);
                           addName(names,name,pos);
                           printf("\n");
                           break;
    //some code here

[MK27]

Well, I notice you did remove the newlines

Are you saying this is never 0?

		   if((strcmpi(temp, temp2))==0){
			comp++;
		   }

[matsp]

        for(i = 1; i < ind; i++){

Should that not be for(i = 0; ... ) ?

           if(c[strlen(c)-1] == '\n') c[strlen(c)-1] = 0;
           strcpy(names[i].name,c);
              else ind++;

What does this do?

--
Mats

[iunah]

Well, I notice you did remove the newlines

Are you saying this is never 0?

		   if((strcmpi(temp, temp2))==0){
			comp++;
		   }

i'm saying that if ever temp and temp2 is 0 (that is, if they are the same), comp's value will change and that would mean the user cannot input the name he wants because it is already existing in the list

[iunah]

        for(i = 1; i < ind; i++){

Should that not be for(i = 0; ... ) ?

           if(c[strlen(c)-1] == '\n') c[strlen(c)-1] = 0;
           strcpy(names[i].name,c);
              else ind++;

What does this do?

--
Mats

it was instructed that index 0 of the array will not be used..

EDIT: my apologies, that was a typo
else is not included..

[matsp]

Yes, I would say that is so. You may just as well throw in a break when you do comp++, since it's not important whether you find one or more matches.

        strcpy(temp,addname);
        for(i = 1; i < ind; i++){
           strcpy(temp2,names[i].name);
		   if((strcmpi(temp, temp2))==0){
			comp++;
		   }
        }

Why do you feel you need to copy the strings here?
You should be able to just pass the original values to strcmpi() without copying the strings.

--
Mats

[Adak]

I'd check that. I believe fgets() will add an end-of-string char to the name, if there is enough room, but it won't take the newline from the buffer.

[laserlight]

I'd check that. I believe fgets() will add an end-of-string char to the name, if there is enough room, but it won't take the newline from the buffer.

It will copy the newline from the buffer to the string, except when there is no space left for the newline (according to the given size). Either way the null terminator will be added.

[iunah]

You should be able to just pass the original values to strcmpi() without copying the strings.

--
Mats

i tried passing the original values but still, nothing happened.. where do you think is the problem?

[MK27]

where do you think is the problem?

That is what I was trying to ask you!

I know what strcmp does and I can see what you intend, but when you complain "it can't compare efficiently those names from the file" I wondered how you know this. So once again, Are you saying this is never 0?

		   if((strcmpi(temp, temp2))==0){
			comp++;
		   }

Like, in reality, if you thru in this:

		   if((strcmpi(temp, temp2))==0){
                        puts("A MATCH!");
			comp++;
		   }

Do they ever match? I am not going to make up an input file, compile and run this program, and I bet no one else is either...if you explain yourself further...get it?

[matsp]

i tried passing the original values but still, nothing happened.. where do you think is the problem?

I don't think your code was WRONG in the part that I posted - just inefficient by needlessly copying strings that didn't need copying - which is bad coding, but not WRONG.

--
Mats

[iunah]

That is what I was trying to ask you!

I know what strcmp does and I can see what you intend, but when you complain "it can't compare efficiently those names from the file" I wondered how you know this. So once again, Are you saying this is never 0?

		   if((strcmpi(temp, temp2))==0){
			comp++;
		   }

Like, in reality, if you thru in this:

		   if((strcmpi(temp, temp2))==0){
                        puts("A MATCH!");
			comp++;
		   }

Do they ever match? I am not going to make up an input file, compile and run this program, and I bet no one else is either...if you explain yourself further...get it?

okay.. for example:

FIle contains:
John
Matt
Philip

then the contents of the array would be that 3 names.. then the user has an option to add a name:

Add a name: jOhn
Warning! Cannot add jOhn because it is already in the list!

to simply put it, jOhn and John is a match..

[matsp]

And how is that different from what you expect?

--
Mats

[iunah]

I don't think your code was WRONG in the part that I posted - just inefficient by needlessly copying strings that didn't need copying - which is bad coding, but not WRONG.

--
Mats

ok.. my bad.. thanks for correcting me

but how about the problem?

[matsp]

I think I've already asked a question as to what you expect.

--
Mats