Fgets problem

[lolguy]

i m trying to finish this mail extractor as exersise for FILE I/O i just learned but so far i goten till check for the @ button this how far i have gotten

#include "includes.h"
#include <stdio.h>
#include <stdlib.h>
#include <time.h>
#include <string.h>
#define FNAME "D:\\Karim test folder\\two.html"
FILE*fptr;
void close_the_file();
void pause();
/*
 *pause()
 *
 *asks the user to press enter
 *this function is used in conjuction with atexit()
 */
void close_the_file()
{

	fclose(fptr);
}

void pause()
{
	printf("\nprogram ended ,Please press enter: ");
	fflush(stdin);
	getchar();
}
int main(void)
{
	 char array[600];
	 int count=0;
	 unsigned int i;
	 atexit(pause);
	 fptr=fopen(FNAME,"r");
	 if(fptr=NULL)
	 {
		 fprintf(stderr,"Coudnt not open \n",FNAME);
		 exit(1);
	 }
        atexit(close_the_file);
        printf("The lines are as follows %s",FNAME);
while(fgets(array,sizeof array,fptr)!=NULL);
			for( i = 0; i <strlen( array ); i++ )
			{
				if(array[i]=='@')
				{
					fputs(array,stdout);
		}
}
return 0;
}

[lolguy]

program compiles but it gets debug error

[MK27]

Why do you call atexit() twice in main like this?

[lolguy]

yah srry mistake should be like this

#include "includes.h"
int main(void)
{
	 char array[600];
	 int count=0;
	 unsigned int i;
	 atexit(close_the_file);
	 atexit(pause);
	 fptr=fopen(FNAME,"r");
	 if(fptr=NULL)
	 {
		 fprintf(stderr,"Coudnt not open \n",FNAME);
		 exit(1);
	 }
        printf("The lines are as follows %s",FNAME);
while(fgets(array,sizeof array,fptr)!=NULL);

			for( i = 0; i <strlen( array ); i++ )
			{
				if(array[i]=='@')
				{
					fputs(array,stdout);
		}
}
return 0;
}

[MK27]

I meant: can you explain why you call atexit() twice in main?

[King Mir]

By the way, you shouldn't need to close the file. C should do that for you automatically.

[lolguy]

i did it because it last thing it does is first do pause function
then closes the file

[happyclown]

By the way, you shouldn't need to close the file. C should do that for you automatically.

Are you saying it's not necessary to close the file only in the OP's situation(program)?

Or do you mean not to use fclose() at all to close files that have been opened with fopen()?

[zacs7]

By the way, you shouldn't need to close the file. C should do that for you automatically.

No... if your implementation does fine, but it's not portable and it's plain stupid.

Also don't use fflush(stdin) -- see the FAQ.

[MK27]

i did it because it last thing it does is first do pause function
then closes the file

Okay, I didn't realize you could call it twice. I notice that it calls them in order of the most recently recieved call. There are a lot of things to be distracted by in this big chunk of code about fgets.

[lolguy]

oke till now i have gotten till here

#include "includes.h"

int main(void)
{
	 char array[600];
     char valid_characters[]="asdfghjklmnbvcxzqwertyuiop";
	 int count=0;
	 int i;
	 int x;
	 atexit(close_the_file);
	 atexit(pause);
	                                                                   /*
	                                                                    *First,open the text file for writing
	                                                                    *and write out the header info to it
	                                                                   */
	 for(x=0;valid_characters[x]!='\0';x++);
	 /*{
		printf("%c\n",valid_characters[x]);
	 }*/
fptr=fopen(FNAME,"r");
if(fptr==NULL)
{
	fprintf(stderr,"Coudnt not open \n",FNAME);
                                                                         /*here we test
																		  *if fopen returns NULL
																		  *then there is a problem happened
																		  *we putted them in stderr and say
																		  *couldnt open file name bla coz bla
																		  *happened :P*/
exit(1);
}

printf("The lines are as follows %s",FNAME);
/*
*write the rest of the header info,including current time
*/
for(;fgets(array,sizeof array,fptr)!=NULL;)
{
	for(i=0;i<strlen(array);i++)
	{
		if(array[i]=='@' && array[i]==valid_characters[x])
		{
			fputs(array,stdout);
		}
	}
}
return 0;
}

[MK27]

What is this:

for(;fgets(array,sizeof array,fptr)!=NULL;)

[lolguy]

it get array till NULL is reached end of file then it quit

[MK27]

So what is your problem?

[lolguy]

well first one didnt work it just pressed all txt :S i need to complete this exersice 2 hours
is very much for it :S

#include "includes.h"

int main(void)
{
	 char array[600];
     char valid_characters[]="asdfghjklmnbvcxzqwertyuiop@";
	 int i;
	 int x;
	 atexit(close_the_file);
	 atexit(pause);
	                                                                   /*
	                                                                    *First,open the text file for writing
	                                                                    *and write out the header info to it
	                                                                   */
fptr=fopen(FNAME,"r");
if(fptr==NULL)
{
	fprintf(stderr,"Coudnt not open \n",FNAME);
                                                                         /*here we test
																		  *if fopen returns NULL
																		  *then there is a problem happened
																		  *we putted them in stderr and say
																		  *couldnt open file name bla coz bla
																		  *happened :P*/
exit(1);
}

printf("The lines are as follows %s",FNAME);
/*
*write the rest of the header info,including current time
*/
for(;fgets(array,sizeof array,fptr)!=NULL;)
{
          for(x=0;valid_characters[x]!='\0';x++)
	{
	for(i=0;i<strlen(array);i++)
	{
	
		if(array[i]==valid_characters[x])
		{
			fputs(array,stdout);
			Sleep(100);
		}
	}
}
}
return 0;
}

that first one didnt work out but now i went into for loop i know its almost fixed i just need lil hints thanks