Thread: linked list question

Hello,

I have this code here that I would like to use to construct two linked lists. one for students and one for courses..

I had it working for just students, that is, before I tried to pass the head and end of the different lists to the init function. Now that I have two different lists, notice the head and end pointers for courses and students, I cannot get this to work. hints?

Code:

 
#include <stdio.h>
#include <alloc.h>
#include <stdlib.h>
#include <conio.h>
#include <ctype.h>
#include <string.h>
 
struct node * initnode( char *, int );
void printnode( struct node * );
void printlist( struct node * );
 
struct node {
   char name[20];
   int  id;
   struct node *next;
   // struct course *myCourse;
};

//struct course {
//   char courseID[7];
//   struct course *next;
//};


struct node *studentHead = (struct node *) NULL;
struct node *studentEnd = (struct node *) NULL;

struct node *courseHead = (struct node *) NULL;
struct node *courseEnd = (struct node *) NULL;

 
struct node * initnode( char *name, int id )
{
   printf("START INIT NODE......");
   struct node *ptr;
   ptr = (struct node *) calloc( 1, sizeof(struct node ) );
   if( ptr == NULL )    {                   /* error allocating node?      */
   printf("INIT NODE ERROR\n");
       return (struct node *) NULL;        /* then return NULL, else      */
       }
   else {                                  /* allocated node successfully */
       strcpy( ptr->name, name );          /* fill in name details        */
       ptr->id = id;                       /* copy id details             */
       printf("INIT NODE COMPLETE\n");
       return ptr;                         /* return pointer to new node  */
   }

}

 

void printlist( struct node *ptr )
{
   printf("printing list...");
   while( ptr != NULL )           /* continue whilst there are nodes left */
   {
      printnode( ptr );           /* print out the current node           */
      ptr = ptr->next;            /* goto the next node in the list       */
   }
}


void printnode( struct node *ptr )
{

   printf("\nName ->%s\n", ptr->name );
   printf("ID   ->%d\n", ptr->id );
}


void insertnode( struct node *newNode, struct node *phead, struct node *pend )
{
   struct node *temp, *prev;                /* similar to deletenode      */

   if( phead == NULL ) {                     /* if an empty list,          */
       printf("set head and end... ");
       phead = newNode;                          /* set 'head' to it           */
       pend = newNode;
       phead->next = NULL;                   /* set end of list to NULL    */
       printf("done.\n");
       return;                              /* and finish                 */
   }

   temp = phead;                             /* start at beginning of list */
                      /* whilst currentname < newname to be inserted then */
   while( strcmp( temp->name, newNode->name) < 0 ) {
          temp = temp->next;                /* goto the next node in list */
          if( temp == NULL )                /* dont go past end of list   */
              break;
   }
   
   if( temp == phead ) {
      newNode->next = phead;             /* link next field to original list   */
      phead = newNode;                   /* head adjusted to new node          */
   }
   else {     /* okay, so its not the first node, a different approach    */
      prev = phead;   /* start of the list, will cycle to node before temp */
      while( prev->next != temp ) {
          prev = prev->next;
      }
      prev->next = newNode;             /* insert node between prev and next  */
      newNode->next = temp;
      if( pend == prev )             /* if the new node is inserted at the */
         pend = newNode;                 /* end of the list the adjust 'end'   */
   }
}



main()
{
   char name[20];
   char cname[10];
   int id;
   struct node *sPtr;
   struct node *crsPtr;

   
   printf("Enter student name ");
   scanf("%s", name );
   printf("Enter in id -- ");
   scanf("%d", &id );
   sPtr = initnode( name, id );
   insertnode( sPtr, studentHead, studentEnd);

   printf("Enter course name ");
   scanf("%s", cname );
   sPtr = initnode( cname, -1 );
   insertnode( sPtr, courseHead, courseEnd);   
   
   // now print
   printlist(studentHead);
   printlist(courseHead);
   
   system("pause");
   
}

You have to pass the heads by reference not by value!

Entire logic of the insertion sort can be put inside the while loop so I see no reason to break from within it and process the head, middle, end of the list separately (just my 2c). When adding to the end of the list you forgot to set the next pointer of newNode to NULL as:

Code:

if( pend == prev ) {          /* if the new node is inserted at the */
    pend = newNode;           /* end of the list the adjust 'end'   */
    pend->next = NULL;
}

Thank you for your time, I have tried that but continue to get errors.

I tried to pass call insertnode like this:

Code:

insertnode( sPtr, &studentHead, &studentEnd);

but still no dice.

please illustrate.

thank you again.

studentHead and studentEnd are pointers so your function call insertnode( sPtr, studentHead, studentEnd) is correct. Being global you don't even need to pass 'em as arguments to insertnode() as they are always there.

Yeah, my bad :S

EDIT: Actually, not my bad. You still have to pass them by reference. Or not pass them at all. What you do is pass the value of the global variables...

Originally Posted by C_ntua

Yeah, my bad :S

EDIT: Actually, not my bad. You still have to pass them by reference. Or not pass them at all. What you do is pass the value of the global variables...

You're right, they need to be called by reference and the OP has 'em coded that way so no need to change the insertnode() call.

The correct insernode call is indeed this:

Code:

insertnode( sPtr, &studentHead, &studentEnd);

and insertNode has to be changed like this:

Code:

void insertnode( struct node *newNode, struct node **phead, struct node **pend )
{
   struct node *temp, *prev;                /* similar to deletenode      */

   if( *phead == NULL ) {                     /* if an empty list,          */
       printf("set head and end... ");
       *phead = newNode;                          /* set 'head' to it           */
       *pend = newNode;
       (*phead)->next = NULL;                   /* set end of list to NULL    */
       printf("done.\n");
       return;                              /* and finish                 */
   }
.........
}

Btw, it would be better not to declare the variables global, since there in no sense doing so...

Originally Posted by itCbitC

You're right, they need to be called by reference and the OP has 'em coded that way so no need to change the insertnode() call.

Are we looking at the same function? I'm looking at

Code:

void insertnode( struct node *newNode, struct node *phead, struct node *pend )

where the head and the end are most definitely not "passed by pointer", but by value.

Originally Posted by tabstop

Are we looking at the same function? I'm looking at

I hope so

Originally Posted by tabstop

Code:

void insertnode( struct node *newNode, struct node *phead, struct node *pend )

where the head and the end are most definitely not "passed by pointer", but by value.

In that function arent' phead and pend being passed as pointers to struct node type unless I don't understand what you're trying to say.

Originally Posted by itCbitC

I hope so

In that function arent' phead and pend being passed as pointers to struct node type unless I don't understand what you're trying to say.

Yes. Since they are pointers to struct node type in the first place, that means they are being passed by value. If you wanted to pass them "by pointer", you would need to have a pointer to a pointer to a struct node.

Ah! yes I see what you're talking about now.

Originally Posted by C_ntua

The correct insernode call is indeed this:

Code:

insertnode( sPtr, &studentHead, &studentEnd);

What the OP currently has is correct too, besides you're adding an extra level of indirection which is unwarranted.

Originally Posted by itCbitC

What the OP currently has is correct too, besides you're adding an extra level of indirection which is unwarranted.

What the OP currently has will not insert a node into the beginning or end of a list, meaning that (among other things) it cannot create a list (an empty list passed in must needs be an empty list coming out, since the beginning or end cannot change).

That's correct for the parameters passed to insertnode() and it should return a value instead of nothing.