Thread: why doesnt this work?

hi,

I have these two functions that declare and alter char* arrays - why dosent it work...? ( i know it dosent i just need some explaning done )

Code:

#include <stdio.h>


void addchars(char *sa[]){

char *name[10];
name[0] = "foo";

sprintf(sa, "%s", name[0]);

}

int main() {

char *sa[128];

printf("numbers: %s\n", sa[0]);
addchars(sa);
printf("numbers: %s\n", sa[0]);


}

thanks!

first thing: enable warnings before compiling, this line is wrong:

Code:

sprintf(sa, "%s", name[0]);

and your compiler would have told you if you asked.

second thing, sa is just an array of pointers, there is no memory allocated for the strings, so sprintf() won't work (segv), replace sprintf() with sa[0]="foo" and you get what you want.