135073

[herWter]

Whenever I run this program(on Linux):

#include <stdio.h>
#include <stdlib.h>
int *letter_count(char *s);
int main(int argc,char **argv)
{
	int *lc=calloc(26,sizeof(char));
	lc=letter_count(argv[1]);
	for(int i=0;i<26;i++)
	{
		printf("%c: %d\n",(char)(i+'a'),lc[i]);
	}
	return 0;
}
int *letter_count(char *s)
{
	int *lc=calloc(26,sizeof(char));
	for(int i=0;s[i];i++)
	{
		lc[(int)(s[i]-'a')]++;
	}
	return lc;
}

I keep getting 135073 for 'k' when no k's has been entered. I tracked it back to the calloc which seems to be where k gets its strange value. Why would calloc produce this number?

[tabstop]

So lc is 26 bytes long. That means you have room to store counts for a, b, c, d, e, and f. Apparently you get lucky with g, h, i, and j, since they should be really really big too. Maybe you should allocate enough space for 26 ints instead?

[herWter]

I meant to use int. Thanks for the catch!

[cyberfish]

haha and nice thread subject you have there.

[Elysia]

You fail to free your allocated memory.

[matsp]

You fail to free your allocated memory.

And you are allocating twice: Once in main, and once in the letter_count function, which is then overwriting the value allocated in main, so you "loose" the original pointer of the memory allocated in main - you should either allocate in main and pass the pointer to the letter_count function, or allocate in the letter_count function only.

--
Mats