Thread: Reading an integer array from console??

Sorry for being a pain but I am google eyed from searching the net with no success..

Basically this is my program, working fine.

Code:

#include <stdio.h>

int main()
{
int Number[14]={1,1,1,1,1,1,1,1,1,1,1,1,1,1};
int i, Calc;

/*Here some fancy calculation happens to
the integer array digits which results in a
single integer value Calc */

printf("%d", Calc);

return 0;
}

Now this all works fine, exactly as expected but what I want to do is promt the user to input the 14 digit number and fill the integer aray using their input.

What I have tried so far:

Code:

scan f("%d %d %d %d.....%d",  &Number[0], &Number[1], &Number[2]....) //etc

Basically scan for 14 integers and store them into each array segment.

The code compiles but the program hangs after inputting any numbers.

I have also tried:

Code:

char Number_In[15];
int Number_Out[14];
int i;

for (i=0;i<14;i++)
{
scanf("%s",Number_In);
Number_Out[i] = atoi(Number_In[i]);
}

Basically inputting a string and using atoi to convert to integer. This however produces the wrong value of Calc digit, and printing the value of Number_Out shows that atoi is not working as expected..

Surely there must be a simple way to do this that I have missed?

Any help greatly receieved,
Cheers.
D.

I'm pretty sure that atoi() works as expected, just that feeding it the address that is the character of the string you read is probably not the right thing. In your loop, you probably should read the string, and then do atoi() on number_in, not number_in[i] - which is a single character, and it is used as an address, so you get a very low memory address as the input to atoi - you are presumably doing this with something like turbo C or an embedded compiler, or your complaint would have been that the program crashes.

Your method that reads 14 integers should also work - however, if you enter less than 14 integers, it will wait for more to be entered, until it has got 14 integer values.

--
Mats

No, of course not. But your loop will read in 14 distinct strings, so your string will not contain 11111111111111 - at least not if you do it right. Your string should be "1", then another string with "1", etc, etc.

Just like your initial exampel doesn't set

Code:

int Number = 11111111111...

, but

Code:

int number[14] = {1, 1, 1, ...};

If you really want to read in ONE string of lots of digits, and then split it into an array of integers, then you would not be using atoi() - perhaps number_in[x] - '0' is the right thing for you? But that doesn't read in an integer array from the console, it converts a string of digits into an array of integers - which is SIMILAR BUT NOT THE SAME.

By the way, atoi("111111111111111") will overflow, so you will get some completely different number back - because the max number in an integer is about 11-12 digits long. atoi does not recognize overflows, but will just continue converting the whole number, and give you back whatever the result is as a 32-bit number (which may be a negative number, even if the input was positive).


--
Mats

Originally Posted by pico

Something really wrong with the internet these days, to much bull$hit messages.

Including your own, since you did not clearly express your requirements, leaving the reader to deduce what you wanted from posts #1 and #3.

Originally Posted by pico

I will put here for countless others with the problem that I saw posting online:

Good to see that you managed to find an answer by searching the Web. However, the answer could be improved by using a char literal instead of a "mysterious" number:

Code:

#include <stdio.h>
#include <stddef.h>

int main()
{
    intArry[3];
    charArry[4]; /* Allow one extra for NULL terminator */
    size_t i;

    scanf("%s", charArry);

    for (i = 0; i < 3; i++)
    {
        intArry[i] = charArry[i] - '0';
    }

    /* ... */
}

See? No need for "magic". Of course, note that this particular use of scanf() is vulnerable to buffer overflow.

Originally Posted by pico

Once again, thanks for your bull$hit answers!

I am giving you an unofficial warning: stop trolling and behave yourself.

And explictly putting the types on the arrays...

Originally Posted by pico

Trolling?

This is my first topic in the forums for 4 years, hardly a troll.

Yes, in your reaction. If you did not get the answer you were looking for here but found it elsewhere, go ahead and post the answer that you found, but there is no need to accuse the replies as being "bull$hit".

Originally Posted by pico

I was explicit with my question, i posted source that I was working on and what I expected / recieved from my program.

Is this not how to ask a question?

The problem is that you posted things related to your actual question, but did not actually present the requirements. It is indeed good to post what you tried, but without knowing exactly what you are trying to do, this secondary information can be misleading.

Consider your statement that you wanted to "Basically scan for 14 integers and store them into each array segment." From the scanf format string, it looks like those 14 integers are delimited by spaces. If you read matsp's reply in post #2, you would see that he indeed assumed as such. Then in post #4 matsp finally made the relevant guess:

Originally Posted by matsp

If you really want to read in ONE string of lots of digits, and then split it into an array of integers, then you would not be using atoi() - perhaps number_in[x] - '0' is the right thing for you? But that doesn't read in an integer array from the console, it converts a string of digits into an array of integers - which is SIMILAR BUT NOT THE SAME.

Unfortunately, you apparently did not notice that guess. (To be honest, neither did I, until further examination of the thread.)

Originally Posted by pico

what I want to do is promt the user to input the 14 digit number and fill the integer aray using their input

That's precisely what I mean by it not being clear: how do you want to fill the integer array? If you changed "fill the integer aray using their input" to "store each digit as a separate integer in the integer array", then I suspect matsp would have went ahead with the number_in[x] - '0' suggestion immediately in post #2, instead of just guessing in post #4.