Thread: Caracter input

i'm confused....

in the first one, secretCode is an integer (but it is initialized as char in main)
and the second one has a char table[] for an argument...

Code:

#include <stdlib.h>
#include <stdio.h>
#include <time.h>

#define NBCOLORS 4
#define NBTRIES 6

char readkey();
void createCode(char code[]);
int playGame(char code[]);

int main (void)
{
    char secretCode[NBCOLORS];
    createCode(secretCode);
    while(playGame(secretCode));
    return 0;
}

// Lecture des coleurs entrees par l'utilisateur

char readkey() {
 //   fflush(stdin);           // Causait des problemes
    char c = '\n';
    while (c == '\n' || c == ' ')
        c = getchar();
    return c;
}

void createCode(char code[])
{
    int i;
    srand(time(NULL));

    /* create random code */
    for (i = 0; i < NBCOLORS; i++)
       switch(rand() &#37; 4)
       {
           case 0: code[i] = 'r'; break;
           case 1: code[i] = 'b'; break;
           case 2: code[i] = 'v'; break;
           case 3: code[i] = 'j'; break;
       }  
}

int playGame(char code[]) {
    char codeCopy[NBCOLORS];
    int victory = 0;
    int i, j, k;
    char c = 0;                         /* character being read */
    char secretCode[NBCOLORS];
    createCode(secretCode);
        
    for (i = 0; i < NBTRIES; i++) {
        int identical = 0;
        int present = 0;
        
        for (j = 0; j < NBCOLORS; j++)
            codeCopy[j] = code[j];
        
        printf("Votre coup (essai no %i): ", i+1);
        
        for (j = 0; j < NBCOLORS; j++) {
            c = readkey();
            if (codeCopy[j] == c) {
                codeCopy[j] = '#';
                identical++;
            }
            else {
                for(k = 0; k < NBCOLORS; k++)
                    if (codeCopy[k] == c) {
                        codeCopy[k] = '#';
                        present++;
                    }
            }
        }
        
        printf("Couleurs identiques: %i\n", identical);
        printf("Coleurs presentes: %i\n", present);
        
        if(identical == NBCOLORS) {
            printf("Bravo! Vous avez trouve notre sequence de couleurs\n");
            victory=1;
            break;
        }
    }
    
    if(!victory) {
        printf("Desole, la sequence de couleurs a deviner etait ");
        for (j = 0; j < NBCOLORS; j++)
            putchar(code[j]);
        putchar('\n');
    }
    
    while (c != 'o' && c != 'O' && c != 'n' && c != 'N') {
        fflush(stdin);
        printf("Voulez-vous jouer une autre partie? (O/N)?");
        c = readkey();
    }
    
    if (c == 'o' || c == 'O')
        return 1;
    return 0;
}

This code runs the program fine and the guessing part seems to be working ok.. but the code is not changing after selecting O.

In the first one, secretCode is most emphatically not an integer. Not not not. Not. secretCode is, in fact, a char[] (that is, an array of char). Notice however that the "char []" part is not passed to the function, since the function doesn't care. It just wants the array itself.

i don't even know what we're talking about anymore. which ones are you referring to ?

why dont you save it to a struct like scanf the string u want and put it in a structure

Originally Posted by lolguy

why dont you save it to a struct like scanf the string u want and put it in a structure

because it's not in the realm of this class :S

i hate it when i just can't make sense of what's going on and get totally lost... i feel like scrapping the whole file because I just can't see what's the problem...

Originally Posted by OrAnGeWorX

i don't even know what we're talking about anymore. which ones are you referring to ?

The two lines I quoted earlier -- the two calls to createCode.

Of course it will. You did change the body of the playGame function to use secretCode instead of code, did you not?

Originally Posted by tabstop

Of course it will. You did change the body of the playGame function to use secretCode instead of code, did you not?

yes i have.. but I'm still getting the same color combination when i choose to replay.

Originally Posted by OrAnGeWorX

yes i have.. but I'm still getting the same color combination when i choose to replay.

Then you didn't change the body. Post what you have.

here goes nothing

Code:

#include <stdlib.h>
#include <stdio.h>
#include <time.h>

#define NBCOLORS 4
#define NBTRIES 6

char readkey();
void createCode(char code[]);
int playGame(char code[]);

int main (void)
{
    char secretCode[NBCOLORS];
    createCode(secretCode);
    while(playGame(secretCode));
    return 0;
}

// Lecture des coleurs entrees par l'utilisateur

char readkey() {
 //   fflush(stdin);           // Causait des problemes
    char c = '\n';
    while (c == '\n' || c == ' ')
        c = getchar();
    return c;
}

void createCode(char code[])
{
    int i;
    srand(time(NULL));

    /* create random code */
    for (i = 0; i < NBCOLORS; i++)
       switch(rand() &#37; 4)
       {
           case 0: code[i] = 'r'; break;
           case 1: code[i] = 'b'; break;
           case 2: code[i] = 'v'; break;
           case 3: code[i] = 'j'; break;
       }  
}

int playGame(char code[]) {
    char codeCopy[NBCOLORS];
    int victory = 0;
    int i, j, k;
    char c = 0;                         /* character being read */
    char secretCode[NBCOLORS];
    createCode(secretCode);
        
    for (i = 0; i < NBTRIES; i++) {
        int identical = 0;
        int present = 0;
        
        for (j = 0; j < NBCOLORS; j++)
            codeCopy[j] = code[j];
        
        printf("Votre coup (essai no %i): ", i+1);
        
        for (j = 0; j < NBCOLORS; j++) {
            c = readkey();
            if (codeCopy[j] == c) {
                codeCopy[j] = '#';
                identical++;
            }
            else {
                for(k = 0; k < NBCOLORS; k++)
                    if (codeCopy[k] == c) {
                        codeCopy[k] = '#';
                        present++;
                    }
            }
        }
        
        printf("Couleurs identiques: %i\n", identical);
        printf("Coleurs presentes: %i\n", present);
        
        if(identical == NBCOLORS) {
            printf("Bravo! Vous avez trouve notre sequence de couleurs\n");
            victory=1;
            break;
        }
    }
    
    if(!victory) {
        printf("Desole, la sequence de couleurs a deviner etait ");
        for (j = 0; j < NBCOLORS; j++)
            putchar(code[j]);
        putchar('\n');
    }
    
    while (c != 'o' && c != 'O' && c != 'n' && c != 'N') {
        fflush(stdin);
        printf("Voulez-vous jouer une autre partie? (O/N)?");
        c = readkey();
    }
    
    if (c == 'o' || c == 'O')
        return 1;
    return 0;
}

Originally Posted by OrAnGeWorX

here goes nothing

Code:

#include <stdlib.h>
#include <stdio.h>
#include <time.h>

#define NBCOLORS 4
#define NBTRIES 6

char readkey();
void createCode(char code[]);
int playGame(char code[]);

int main (void)
{
    char secretCode[NBCOLORS];
    createCode(secretCode);
    while(playGame(secretCode));
    return 0;
}

// Lecture des coleurs entrees par l'utilisateur

char readkey() {
 //   fflush(stdin);           // Causait des problemes
    char c = '\n';
    while (c == '\n' || c == ' ')
        c = getchar();
    return c;
}

void createCode(char code[])
{
    int i;
    srand(time(NULL));

    /* create random code */
    for (i = 0; i < NBCOLORS; i++)
       switch(rand() % 4)
       {
           case 0: code[i] = 'r'; break;
           case 1: code[i] = 'b'; break;
           case 2: code[i] = 'v'; break;
           case 3: code[i] = 'j'; break;
       }  
}

int playGame(char code[]) {
    char codeCopy[NBCOLORS];
    int victory = 0;
    int i, j, k;
    char c = 0;                         /* character being read */
    char secretCode[NBCOLORS];
    createCode(secretCode);
        
    for (i = 0; i < NBTRIES; i++) {
        int identical = 0;
        int present = 0;
        
        for (j = 0; j < NBCOLORS; j++)
            codeCopy[j] = code[j];  /*you told me you changed this to secretcode but you didn't */
        
        printf("Votre coup (essai no %i): ", i+1);
        
        for (j = 0; j < NBCOLORS; j++) {
            c = readkey();
            if (codeCopy[j] == c) {
                codeCopy[j] = '#';
                identical++;
            }
            else {
                for(k = 0; k < NBCOLORS; k++)
                    if (codeCopy[k] == c) {
                        codeCopy[k] = '#';
                        present++;
                    }
            }
        }
        
        printf("Couleurs identiques: %i\n", identical);
        printf("Coleurs presentes: %i\n", present);
        
        if(identical == NBCOLORS) {
            printf("Bravo! Vous avez trouve notre sequence de couleurs\n");
            victory=1;
            break;
        }
    }
    
    if(!victory) {
        printf("Desole, la sequence de couleurs a deviner etait ");
        for (j = 0; j < NBCOLORS; j++)
            putchar(code[j]);
        putchar('\n');
    }
    
    while (c != 'o' && c != 'O' && c != 'n' && c != 'N') {
        fflush(stdin);
        printf("Voulez-vous jouer une autre partie? (O/N)?");
        c = readkey();
    }
    
    if (c == 'o' || c == 'O')
        return 1;
    return 0;
}

If you lie to us about what you changed, how can we help you?

Originally Posted by OrAnGeWorX

I'm certainly not lying but rather lost...

I said:

Originally Posted by tabstop

Of course it will. You did change the body of the playGame function to use secretCode instead of code, did you not?

Note that code is used one place in the body of the playGame function, namely here:

Code:

 codeCopy[j] = code[j];

You responded with:

Originally Posted by OrAnGeWorX

yes i have.. but I'm still getting the same color combination when i choose to replay.

And yet, when you posted your code, the one place that there was to change, didn't change. What did you think you had to change, if not the one place in the code where the variable was used?

i misunderstood what you meant, i'm sorry, i believed u meant something else... it's been a few days that i'm not getting sleep and i'm just staring at the pc screens and i have the final exam tomorrow. so i'm a little edgy and stressed out. your comments have been helpful in the general area but confusing me because i did not write the whole program, i had a friend help me out a little.
the codeCopy table is there to compare the user's entry code with the generated secretCode (since codeCopy is the same as secretCode and we don't want modifications on the original)