Binary Tree and File I/O

[Matus]

Ok im printing a tree in ascending order, on the monitor it does it quite well. But what i wanted to do was to print the same thing that pops on screen to a text file, it does print it but not in order. For instance if i enter, "jake,bert,zena" on screen its ok like "bert,jake,zena", but when written to a file it comes out as "bert,zena,jake"

Can anyone point out my crappy logic, or help me out in fixing it? Thanks! There is the code:

void printtree_asc(BST t)
{
    FILE *dataOutput;
    dataOutput = fopen("fileOutput.txt","a+"); 
    
    if (dataOutput == NULL) {
    printf("OooooPppppsss Out of Memory!");
    sleep(3);
    exit (-1);
    }

    if (t!=NULL) {
   	printtree_asc(t->left);
    printf("\n %d \t %s",t->info,t->fname);
    fputs(t->fname,dataOutput);
    fputs("\n",dataOutput);
    printtree_asc(t->right);
    
    }
   fclose(dataOutput);
}

[master5001]

Ok im printing a tree in ascending order, on the monitor it does it quite well. But what i wanted to do was to print the same thing that pops on screen to a text file, it does print it but not in order. For instance if i enter, "jake,bert,zena" on screen its ok like "bert,jake,zena", but when written to a file it comes out as "bert,zena,jake"

Can anyone point out my crappy logic, or help me out in fixing it? Thanks! There is the code:

 
void printtree_asc(BST t)
{
    FILE *dataOutput;
    dataOutput = fopen("fileOutput.txt","a+");
 
    if (dataOutput == NULL) {
    printf("OooooPppppsss Out of Memory!");
    sleep(3);
    exit (-1);
    }
 
    if (t!=NULL) {
       printtree_asc(t->left);
    printf("\n %d \t %s",t->info,t->fname);
    fputs(t->fname,dataOutput);
    fputs("\n",dataOutput);
    printtree_asc(t->right);
 
    }
   fclose(dataOutput);
}

Hmmmm I wouldn't open a file like that. You do realize you can only open a file handle so many times. Personally, I would just pass the FILE as a parameter.

[Matus]

Hmmmm I wouldn't open a file like that. You do realize you can only open a file handle so many times. Personally, I would just pass the FILE as a parameter.

Sorry could u explain Matt, do u mean the a+, i tried using only "w", but only jake would be printed nothing else.

[master5001]

Example:

/* be sure to include assert.h for the assert() function */

void printtree_asc(BST t, FILE *dataOutput)
{
    assert(dataOutput);
 
    if (t!=NULL) {
       printtree_asc(t->left, dataOutput);
       printf("\n %d \t %s",t->info,t->fname);
       fputs(t->fname,dataOutput);
       fputs("\n",dataOutput);
       printtree_asc(t->right, dataOutput);
    }
}

[Matus]

Example:

So in main is where id actually be doing the FILE I/O opening right, and then passing it to the function as one of its arguments?

Am i understanding correct?

[master5001]

Correctomundo. The problem with doing it how you had it before, is the file handles may not be opened, closed, nor flushed in the correct order. Which as far as I can see may be why your other stuff wasn't working right. Opening a file is expensive anyway.

[Dino]

Matus wants to print a tree
And got some advice from Master-ee
The File Handle isn't a problem, the fclose() is done too
We all make mistakes, I don't think that's the issue.

Now, I wouldn't design a routine like this
But it's a common mistake for a newbie novice
Manage the handle in the main line code once
And then you won't look like a dunce.

C is a great language to learn
But these common mistakes you'll soon discern
In some months to come, you'll answer a post
And rightfully so, it'll be your time to boast.

Don't expect me to rhyme every time I reply
Sometime's my mind's blank, I cannot comply
But this evening I felt like I might have luck,
Thank goodness for rhyming web sites, else I'd be stuck

[Matus]

Correctomundo. The problem with doing it how you had it before, is the file handles may not be opened, closed, nor flushed in the correct order. Which as far as I can see may be why your other stuff wasn't working right. Opening a file is expensive anyway.

Alright Matt, yea that was the problem, think im comprehending what you were saying about the opening, got it thanks man. "Again"

Owe u big time!

[Matus]

Matus wants to print a tree
And got some advice from Master-ee
The File Handle isn't a problem, the fclose() is done too
We all make mistakes, I don't think that's the issue.

Now, I wouldn't design a routine like this
But it's a common mistake for a newbie novice
Manage the handle in the main line code once
And then you won't look like a dunce.

C is a great language to learn
But these common mistakes you'll soon discern
In some months to come, you'll answer a post
And rightfully so, it'll be your time to boast.

Don't expect me to rhyme every time I reply
Sometime's my mind's blank, I cannot comply
But this evening I felt like I might have luck,
Thank goodness for rhyming web sites, else I'd be stuck

Haha, another good one Dino. Yea thanks for the advice, hopefully im getting there. Another best quote of the month you gota say!

[master5001]

You could do it your way, you just have to open your file at the inner most point of the recursion. But even then I do not recommend that since again, opening a file is expensive.

[master5001]

Here is the other way I speak of, just so you don't live life always kind of wondering.

Example:

void printtree_asc(BST t)
{
    FILE *dataOutput;
 
    if (t!=NULL) {
       printtree_asc(t->left);

       dataOutput = fopen("fileOutput.txt","a+");
 
       if (dataOutput == NULL) {
          printf("OooooPppppsss Out of Memory!");
          sleep(3);
          exit (-1);
       }

       printf("\n %d \t %s",t->info,t->fname);
       fputs(t->fname,dataOutput);
       fputs("\n",dataOutput);
       fclose(dataOutput);

       printtree_asc(t->right);
    }
}

[Matus]

You could do it your way, you just have to open your file at the inner most point of the recursion. But even then I do not recommend that since again, opening a file is expensive.

Alright thanks, now I see. I'll take note of the File opening operations. Thanks. Owe u

[master5001]

Nah its cool. Just use your knowledge wisely and we are even

[matsp]

    printf("OooooPppppsss Out of Memory!");

isn't the right error message when you can't open a file, right?

--
Mats

[Matus]

    printf("OooooPppppsss Out of Memory!");

isn't the right error message when you can't open a file, right?

--
Mats

Ya i know, i changed that part too, with the standard error stuff, as i'v quite actually seen on other posts before.