Thread: Strange error and impending sanity loss

Well, either you lost me somewhere along the very short road, or something else is not as it should be, because I still can't get it to write properly.

Hehe, I'm sure you can punch many, and you're welcome to as long as I can patch them up again.

I didn't change much from the code I posted aside from the two you pointed out. Basically

Code:

    if (fwrite(test, sizeof(test[0]), 11, fil) != 1){

and

Code:

    fread(highscore, sizeof(highscore[0]), 11, stream);

Secondly, you tell fwrite to write the size of the type it points to, since all elements in an array are the same size, test[0] is the same size as test[1], etc.
And that size is not necessarily the size of a pointer. Oh no. Undefined behavior right there.

I'm not clear on what you meant with this, so I didn't change it. I thought declaring the size of the element is what I wanted to do.

Originally Posted by Maer

Hehe, I'm sure you can punch many, and you're welcome to as long as I can patch them up again.

I didn't change much from the code I posted aside from the two you pointed out.

I'm not clear on what you meant with this, so I didn't change it. I thought declaring the size of the element is what I wanted to do.

But that doesn't help us know what you've changed, from which version of what was posted, etc.

As to the second, you want to declare the size of the element. Using sizeof(highscore) doesn't give you the size of the element, since highscore isn't an element, it's a pointer.

But that doesn't help us know what you've changed, from which version of what was posted, etc

Finally, something I can fix.



highscore.h

Code:

#ifndef HIGHSCORE_H_
#define HIGHSCORE_H_

extern int highscore[];
extern int test[];


//void InsertScore(int *highscore);

int SaveHighscore(int *test);
 
void LoadHighscore(int *highscore);


#endif /*HIGHSCORE_H_*/

highscore.c

Code:

#include <stdio.h>
#include <stdlib.h>
#include <errno.h>
#include "highscore.h"

// open file
int SaveHighscore(int *test)
{
    FILE *fil;


    fil = fopen("highscore.txt", "w");
    if (fil == NULL) {
        printf("Unable to open file\n");
        goto error;
        }
    fwrite(test, sizeof(test[0]), 11, fil);    
    if (fwrite(test, sizeof(test[0]), 11, fil) != 1){
        printf("Unable to write to file\n");
        goto error;
        }
    fclose(fil);
    
    return 1;
    
    error:
        return 0;
}


void LoadHighscore(int *highscore)
{
    FILE *stream;
    int i;
    
    
    stream = fopen("highscore.txt", "r");
    
    
    if(stream==NULL) {
        printf("Error: can't open file.\n");
    }
  else {
    printf("File opened.\n");
  }
        
    fread(highscore, sizeof(highscore[0]), 11, stream);
    for(i=0; i<11; i++){
    printf("File read: %d \n", highscore[i]);
    }
    fclose(stream);
    
}

main.c

Code:

#include <stdlib.h>
#include <stdio.h>
#include <math.h>
#include <unistd.h>
#include <assert.h>
#include "SDL.h"
#include "SDL_ttf.h"
#include "drawline.h"
#include "triangle.h"
#include "teapot_data.h"
#include "sphere_data.h"
#include "object.h"
#include "text.h"
#include "list.h"
#include "highscore.h"

(snip)



int highscore[11] = {1,1,2,3,4,5,6,7,8,9,9};
int test[11] = {2,2,2,2,2,2,2,2,2,2,2};

(snip)

int main(int argc, char **argv)
{
    // Start game
    while (1) {
  

        
        SaveHighscore(test);
        LoadHighscore(highscore);

Thanks for all the help, it's muchly appreciated. I finally got it to work.