Thread: For some reason I end up with memory leak...

Originally Posted by zacs7

Code:

void releaseMemory ( COUNTRY *list )
{
// Local Declarations
	int i;

// Statements
	for ( i = 0; i <= 21; i++ )
	{
		free ( list[i].id );
		free ( list[i].name );
		free ( list[i].capital );
		free ( list[i].population );
	}

   return;
}

Where does this magic 21 come from? free()'ing non-NULL pointers that you didn't allocate is very bad.

Also don't use gets() -- see the FAQ.

I just put in 21 to see whether or not I freed the memory correctly. 21 is numCountries -1. The list's variables carry pointers to tempInt, tempName, tempCap, and tempPop. I also don't like using fgets in this situation because it carries over the '\n' as well.