issues

last results of the run

SVP entrez le nombre d'animaux pour vos calculs:
2
Animal 1
entrez sexe (M/F)
F
entrez l age en jours
12
entrez le poids en kg
.5
entrez la longueur en cm
13
Animal 2
entrez sexe (M/F)
F
entrez l age en jours
12
entrez le poids en kg
.34
entrez la longueur en cm
55
sexe: F age: 1095761920poids: 13.000000taille: 13.000000
sexe: F age: 1113325568poids: 55.000000taille: 55.000000
Nombre de males: 0
Nombre de femelles: 2
Nombre de femelles pesant moins de 1kg: 2
Taille plus grande: 55.00 et taille plus courte: 13.00

Voulez vous faire un autre calcul, (o/n)?

there are 2 problems in this output:
1- age is meaningless
2- in the "debug" section, program is printing the same values for taille and poids, namely taille's values.

I believe i have a problem with the females < 1.0kg counter as well
:(
i'm gonna lose my mind!

edit: i retried the program a few times with several different sets of numbers and at times the females <1kg shows up right and other times, wrong... i believe there's gotta be a memory flush somewhere
and the age is still wrong...

i'm stumped

The fix for this is incredibly simple: you cannot declare the array until after you ask the user how many animals there are. Using an uninitialized nbrAnimaux means you are trying to create several million (or worse, a negative number of) animals. Using an uninitialized value, or a negative number, and the program can do whatever it wants, up to and including playing "Oh Canada" through the speakers.

i'm even more confused than before

i tried moving the table declarations after the scanf for nbrAnimaux and got a ton of errors...

Quote:

Originally Posted by OrAnGeWorX

i'm even more confused than before

i tried moving the table declarations after the scanf for nbrAnimaux and got a ton of errors...

Well ... surely you're in C99 mode? What kind of errors?

i have no idea what C99 mode is but i can tell u this, it's intro to programming...

Here's the new code

Code:

/* Ce programme saisi des données sur des animaux etudiés par une biologiste: - 1ere ligne, leur nombre, pour créer les tableaux qui contiendront les infos - 2eme ligne et + (jusqu'au nombre saisi à la première ligne), leur sexe (M ou F, char), leur age (en jours, int), leur poids (en kg, réel) et leur taille (en cm, réel) et affiche des résultats selon ces critères: - les coordonnées des males de plus de 30cm - le nombre de femelles qui pèsent moins de 1.0 kg - l'age moyen des femelles et celui des males - la longueur minimale et maximale des animaux */ #include <stdio.h> #include <stdlib.h> #include <ctype.h> #define HAUTEUR 30.0 #define POIDS 1.0 int main() { // initialisation des variables int nbrAnimaux=0; // Valeur que specifie l'usager pour creer les tableaux int nbrMale=0; // compteur animaux males int nbrFemelle=0; // compteur des femelles //int coordMG=0; // compteur des animaux > 30cm de longueur int nbrFemelleL=0; // compteur des femelles < 1kg int i, j; // compteur boucle int ageTotalM=0; // age total et moyen des males int ageTotalF=0; // age total et moyen des femelles int ageMoyenM, ageMoyenF; float taillePlusCourte=5000; float taillePlusGrande=0; char condition; // Oui ou Non // Boucle do ... while, pour ne pas devoir repartir le programme pour chaque calcul do { // Saisi et lecture des donnees printf("SVP entrez le nombre d'animaux pour vos calculs:\n"); scanf("%d", &nbrAnimaux); float taille[nbrAnimaux], poids[nbrAnimaux]; // moved the table declarations int age[nbrAnimaux]; char sexe[nbrAnimaux]; // printf("Maintenant, SVP entrez les details comme ceci, \nSexe (M/F), Age, Poids et Longueur\n"); for (i = 1; i <= nbrAnimaux; i++) { printf("Animal %d\n", i); printf("entrez sexe (M/F)\n"); fflush(stdin); scanf("%c", &sexe[i]); printf("entrez l age en jours\n"); fflush(stdin); scanf("%d", &age[i]); printf("entrez le poids en kg\n"); fflush(stdin); scanf("%f", &poids[i]); printf("entrez la longueur en cm\n"); fflush(stdin); scanf("%f", &taille[i]); } // debug for (i = 1; i <=nbrAnimaux; i++) { printf("sexe: %c ", sexe[i]); printf("age: %d", age[i]); printf("poids: %f", poids[i]); printf("taille: %f\n", taille[i]); } // end debug for (j = 1; j <= nbrAnimaux; j++) { if (toupper(sexe[j]) == 'M') // Compter les males et femelles { nbrMale++; ageTotalM += age[j]; } else { nbrFemelle++; ageTotalF += age[j]; } if (toupper(sexe[j]) == 'F' && poids[j] < POIDS) // something wrong with this... always returns 0 nbrFemelleL++; if (toupper(sexe[j]) == 'M' && taille[j] > HAUTEUR) // this works on the other hand printf ("Coordonnes du rang Male > 30cm: %d\n", j); if (taille[j] < taillePlusCourte) taillePlusCourte = taille[j]; if (taille [j] > taillePlusGrande) taillePlusGrande = taille[j]; } // ageMoyenM = ageTotalM / nbrMale; // added these for average // ageMoyenF = ageTotalF / nbrFemelle; // male and female age //printf("Nombre de males: %d\n", nbrMale); //printf("Nombre de femelles: %d\n", nbrFemelle); printf("Nombre de femelles pesant moins de 1kg: %d\n", nbrFemelleL); // printf("Age moyen des males %d et l\'age moyen des femelles: %d\n", ageMoyenM, ageMoyenF); // commented this line because it's crashing the program printf("Taille plus grande: %6.2f et taille plus courte: %6.2f\n", taillePlusGrande, taillePlusCourte); // debug // for (i = 0; 1<nbrAnimaux; i++) // printf ("a la case %d, le sexe est %c, l'age est %d, le poids est %f et la longueur est %f", i, sexe[i], age[i], poids[i], taille[i]); // end debug // Condition requise pour repartir du début printf ("\nVoulez vous faire un autre calcul, (o/n)?"); fflush (stdin); // Fonction pour vider stdin condition = toupper(getchar()); // Capitaliser la letter et soumettre à condition } while ( condition == 'O'); // Repartir du début si O // fin du do while restart }

the errors i got were
parse error before 'float' for the line
float taille[nbrAnimaux], poids[nbrAnimaux]; // moved the table declarations

then sexe, age, poids and taille... says undeclared (first use in this function) and that's in the first for loop (obviously coz i declared the tables in the do loop...
that mean i have to initiate the tables in the for loop that stores the info, right ?

ok... i tried moving the declarations into the first loop thinking that it works all over since they're created...
it's now asking me to declare them for the next for loop

not so much an easy fix i'm seeing

I don't know what compiler you're using. You could declare arrays with variable sizes, which wasn't legal in the older C89, so either you're in C99 or some older compiler with a very limited extension list. Anyway, I tried your code out on Comeau's online compiler, and got

Code:

Comeau C/C++ 4.3.10.1 (Oct 6 2008 11:28:09) for ONLINE_EVALUATION_BETA2 Copyright 1988-2008 Comeau Computing. All rights reserved. MODE:strict errors C99 "ComeauTest.c", line 30: warning: variable "ageMoyenM" was declared but never referenced int ageMoyenM, ageMoyenF; ^ "ComeauTest.c", line 30: warning: variable "ageMoyenF" was declared but never referenced int ageMoyenM, ageMoyenF; ^

warnings for two variables you never used, but everything else worked out.

On the no-reason-for-it assumption you're using gcc, make sure you have -std=C99 somewhere on your compilation line.

after reverting to the original position
i reran the program... it didn't crash and no errors
we already established that the age was messed up but why would the loop i use to print out the contents of the tables kind of scramble the information
it's printing out the same info for poids and taille

SVP entrez le nombre d'animaux pour vos calculs:
1
Animal 1
entrez sexe (M/F)
M
entrez l age en jours
1
entrez le poids en kg
2
entrez la longueur en cm
3
sexe: M age: 1077936128poids: 3.000000taille: 3.000000
Nombre de femelles pesant moins de 1kg: 0
Taille plus grande: 3.00 et taille plus courte: 3.00

Voulez vous faire un autre calcul, (o/n)?

Quote:

Originally Posted by tabstop

I don't know what compiler you're using. You could declare arrays with variable sizes, which wasn't legal in the older C89, so either you're in C99 or some older compiler with a very limited extension list. Anyway, I tried your code out on Comeau's online compiler, and got

Code:

Comeau C/C++ 4.3.10.1 (Oct 6 2008 11:28:09) for ONLINE_EVALUATION_BETA2 Copyright 1988-2008 Comeau Computing. All rights reserved. MODE:strict errors C99 "ComeauTest.c", line 30: warning: variable "ageMoyenM" was declared but never referenced int ageMoyenM, ageMoyenF; ^ "ComeauTest.c", line 30: warning: variable "ageMoyenF" was declared but never referenced int ageMoyenM, ageMoyenF; ^

warnings for two variables you never used, but everything else worked out.

On the no-reason-for-it assumption you're using gcc, make sure you have -std=C99 somewhere on your compilation line.

i'm using Dev-C++ v4
the ageMoyenM and ageMoyenF are for the age average for males and females... i had commented out the lines that calculate these as they were crashing the program for some reason.

Quote:

Originally Posted by OrAnGeWorX

i'm using Dev-C++ v4
the ageMoyenM and ageMoyenF are for the age average for males and females... i had commented out the lines that calculate these as they were crashing the program for some reason.

So that's gcc then. I am not currently sitting at a machine with Dev-C++ on it, so I don't remember exactly where, but either (1) there's a checkbox for it in the options or (2) there isn't a checkbox for it in the options, but you can add it to the command line in the options.

in the options, would it be attempt to support some aspects of traditional C preprocessors?

running the program again... only using males

results:
SVP entrez le nombre d'animaux pour vos calculs:
2
Animal 1
entrez sexe (M/F)
M
entrez l age en jours
12
entrez le poids en kg
34
entrez la longueur en cm
56
Animal 2
entrez sexe (M/F)
M
entrez l age en jours
98
entrez le poids en kg
12
entrez la longueur en cm
20
sexe: M age: 1113587712 poids: 56.000000 taille: 56.000000
sexe: M age: 1101004800 poids: 20.000000 taille: 20.000000
>>> poids and taille can't be the same >>> how's that happening ?
Coordonnes du rang Male > 30cm: 1
Nombre de femelles pesant moins de 1kg: 0
Taille plus grande: 56.00 et taille plus courte: 20.00

Voulez vous faire un autre calcul, (o/n)?

ran it for only females
===============
SVP entrez le nombre d'animaux pour vos calculs:
2
Animal 1
entrez sexe (M/F)
F
entrez l age en jours
12
entrez le poids en kg
.5
entrez la longueur en cm
14
Animal 2
entrez sexe (M/F)
F
entrez l age en jours
432
entrez le poids en kg
1.2
entrez la longueur en cm
43
sexe: F age: 1096810496 poids: 14.000000 taille: 14.000000
sexe: F age: 1110179840 poids: 43.000000 taille: 43.000000
>>> age is wrong, poids and taille are same here as well
Nombre de femelles pesant moins de 1kg: 0
>>> should be 1 (that was working earlier)
Taille plus grande: 43.00 et taille plus courte: 14.00

Voulez vous faire un autre calcul, (o/n)?

i'm thinking i should just give up at this point... i feel like it's going nowhere.

No. If it doesn't say "C99" it's not what you want.

Go back one tab to Compiler and it's "Add these commands when calling compiler" or similar. (The command you should add is "-std=c99" without quotes.)

Quote:

Originally Posted by tabstop

No. If it doesn't say "C99" it's not what you want.

Go back one tab to Compiler and it's "Add these commands when calling compiler" or similar. (The command you should add is "-std=c99" without quotes.)

when i open the compiling window, i have execute paramets... i put in -std=c99 as you directed...
nothing changed, nothing "visible" that is.

tabstop... i really appreciate the help